Files
punktfunk/clients/apple/Tests/LumenKitTests/AnnexBTests.swift
T
enricobuehler bf8a974e8b
ci / rust (push) Has been cancelled
feat: M4 stage 1 — the SwiftUI client is real: compiles, tested, first light on glass
The clients/apple scaffold is now a working macOS client, validated live against this
repo's host across the LAN: gamescope virtual output → NVENC HEVC → lumen/1 (GF(2¹⁶) FEC +
AES-GCM over UDP, QUIC control) → VideoToolbox → AVSampleBufferDisplayLayer at 720p60,
mouse/keyboard flowing back as QUIC datagrams into the host's gamescope EIS injector
(~3.7k events injected in one session).

LumenKit:
- LumenConnection: the predicted cbindgen compile fixes (C17 header spells the typedefs as
  integers while the enum constants import as a distinct Swift type — bridge by rawValue);
  close() is now safe from any thread (a close flag + pumpLock held across the blocking
  poll enforce the C contract "never close with a next_au in flight"; flag prevents
  lock-starvation by back-to-back polls).
- StreamView: per-pump cancellation token (reconnects can't double-pump), flush + re-gate
  on the next in-band parameter sets when the layer fails, no stale enqueue after restart.
- InputCapture: fractional-delta accumulation (sub-pixel motion isn't truncated away),
  pressed-state tracking with release-all on focus loss and stop() (nothing sticks down
  host-side), global-singleton ownership guard (GC has one handler slot per process),
  X1/X2 buttons, horizontal scroll, full keypad/CapsLock/ISO-102nd/PrintScreen/Menu VKs.
- LumenClient app shell (swift run LumenClient): connect form, fps/Mb-s HUD,
  LUMEN_AUTOCONNECT/LUMEN_MODE for scripted first-light runs.
- Tests: Annex-B byte-level units; real-codec round trip (VTCompressionSession-encoded
  HEVC rebuilt as the host's wire shape → AnnexB → VTDecompressionSession → pixels);
  test-loopback.sh (Swift client vs a real local m3-host over loopback — the Swift twin of
  c_abi_connection_roundtrip); RemoteFirstLightTests (full pipeline over the LAN).

Host/build fixes that fell out:
- The workspace builds on non-Linux again: gamestream audio (opus) and sendmmsg batching
  are now platform-gated with stubs/fallback, per the crate's "compiles everywhere" rule.
- Horizontal scroll was inverted end-to-end: the injectors negated BOTH axes onto the
  ei/wl axes, but GameStream's horizontal convention is positive = right
  (moonlight-qt/Sunshine pass it through unnegated) — only vertical flips now. This also
  un-inverts real Moonlight clients.
- AnnexB drops all zeros preceding a start code (trailing_zero_8bits padding), ffmpeg's
  policy, instead of leaking them into the preceding NAL.
- build-xcframework.sh: deployment targets pinned to the package floor + an otool guard —
  cargo does not fingerprint MACOSX_DEPLOYMENT_TARGET, so warm caches can silently ship
  too-new minos objects.

Adversarially reviewed (5-dimension multi-agent pass, every finding refutation-verified):
14 confirmed findings, all fixed above; the send-while-polling core-contract gap flagged
here is closed by the lumen/1 session-planes work (&self pulls + per-plane borrow slots).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-10 14:46:45 +02:00

80 lines
2.7 KiB
Swift

// Unit tests for the Annex-B AVCC plumbing (pure byte-level; no codec involved
// VideoToolboxRoundTripTests covers the real-bitstream path).
import XCTest
@testable import LumenKit
final class AnnexBTests: XCTestCase {
/// NAL with the given HEVC type in bits 1..6 of the first header byte.
private func nal(type: UInt8, payload: [UInt8]) -> Data {
Data([type << 1, 0x01] + payload)
}
private let start4: [UInt8] = [0, 0, 0, 1]
private let start3: [UInt8] = [0, 0, 1]
func testSplitMixedStartCodes() {
let a = nal(type: 32, payload: [0xAA])
let b = nal(type: 33, payload: [0xBB, 0xBC])
let c = nal(type: 19, payload: [0xCC, 0xCD, 0xCE])
var au = Data(start4)
au.append(a)
au.append(contentsOf: start3)
au.append(b)
au.append(contentsOf: start4)
au.append(c)
let nals = AnnexB.nalUnits(in: au)
XCTAssertEqual(nals, [a, b, c])
XCTAssertEqual(nals.map(AnnexB.hevcNalType), [32, 33, 19])
}
func testSplitSingleNalNoTrailingCode() {
let v = nal(type: 34, payload: [1, 2, 3])
let au = Data(start3) + v
XCTAssertEqual(AnnexB.nalUnits(in: au), [v])
}
func testSplitEmptyAndGarbage() {
XCTAssertEqual(AnnexB.nalUnits(in: Data()), [])
// No start code at all no NALs.
XCTAssertEqual(AnnexB.nalUnits(in: Data([9, 8, 7, 6])), [])
}
func testSplitDropsTrailingZeroPadding() {
// trailing_zero_8bits between NALs (and >2 zeros forming a long separator) must
// not leak into the preceding NAL.
let a = nal(type: 33, payload: [0xAA])
let b = nal(type: 19, payload: [0xBB])
var au = Data(start4)
au.append(a)
au.append(contentsOf: [0, 0, 0, 0, 0, 1]) // padding + start code
au.append(b)
XCTAssertEqual(AnnexB.nalUnits(in: au), [a, b])
}
func testAvccDropsParameterSetsAndPrefixesLengths() {
let vps = nal(type: 32, payload: [0xAA])
let sps = nal(type: 33, payload: [0xBB])
let pps = nal(type: 34, payload: [0xCC])
let idr = nal(type: 19, payload: [0xDD, 0xDE, 0xDF, 0xE0])
var au = Data()
for n in [vps, sps, pps, idr] {
au.append(contentsOf: start4)
au.append(n)
}
let avcc = AnnexB.avcc(from: au)
// Only the IDR survives: 4-byte BE length, then the NAL bytes.
var expected = Data([0, 0, 0, UInt8(idr.count)])
expected.append(idr)
XCTAssertEqual(avcc, expected)
}
func testFormatDescriptionNilWithoutParameterSets() {
let idr = nal(type: 19, payload: [0xDD])
let au = Data(start4) + idr
XCTAssertNil(AnnexB.formatDescription(fromIDR: au))
}
}