fix(ci): unbreak the main gates — clippy checked_div, isolate docs #487

Merged

enricobuehler merged 1 commits from fix/ci-main-clippy-docs into main 2026-09-01 09:51:42 +00:00

Conversation 0 Commits 1 Files Changed 2

+2 -5

enricobuehler commented 2026-09-01 01:54:51 +00:00

Owner

Copy Link

Copy Source

Main's push CI fails on two code gates plus one infra problem.

Clippy (rust + rust-arm64): the 1.96 toolchain's new clippy::manual_checked_ops fires on mu-smoke's guarded average division (if audio_pkts > 0 { audio_bytes / audio_pkts } else { 0 }). Rewritten as audio_bytes.checked_div(audio_pkts).unwrap_or(0) — same value, lint-clean. The example is Linux-only (the client module is configured out on macOS), so the CI clippy run is the authoritative check here.

Docs drift: PUNKTFUNK_GAMESCOPE_ISOLATE (from the gamescope multi-user isolation work) had no docs-site entry. It is a real operator-facing escape hatch, not an internal knob, so it gets a configuration.md table row next to its gamescope siblings rather than a baseline entry. Verified locally: scripts/ci/check-docs-drift.sh passes.

Not in this PR — runner infra: the swift and host check job failures were No space left on device on the macOS runner (home-mac-mini-1). Cleaned up out-of-band: erased the three CI screenshot simulators (~31 G of accumulated device data) and pruned unavailable devices; the Data volume went from ~16 G to ~26 G free. A further 12 G sits in root-owned /Library/Developer/CoreSimulator/Caches (regenerable dyld caches) that needs an interactive sudo to clear.

Main's push CI fails on two code gates plus one infra problem. **Clippy (`rust` + `rust-arm64`)**: the 1.96 toolchain's new `clippy::manual_checked_ops` fires on `mu-smoke`'s guarded average division (`if audio_pkts > 0 { audio_bytes / audio_pkts } else { 0 }`). Rewritten as `audio_bytes.checked_div(audio_pkts).unwrap_or(0)` — same value, lint-clean. The example is Linux-only (the `client` module is configured out on macOS), so the CI clippy run is the authoritative check here. **Docs drift**: `PUNKTFUNK_GAMESCOPE_ISOLATE` (from the gamescope multi-user isolation work) had no docs-site entry. It is a real operator-facing escape hatch, not an internal knob, so it gets a `configuration.md` table row next to its gamescope siblings rather than a baseline entry. Verified locally: `scripts/ci/check-docs-drift.sh` passes. **Not in this PR — runner infra**: the `swift` and host `check` job failures were `No space left on device` on the macOS runner (home-mac-mini-1). Cleaned up out-of-band: erased the three CI screenshot simulators (~31 G of accumulated device data) and pruned unavailable devices; the Data volume went from ~16 G to ~26 G free. A further 12 G sits in root-owned `/Library/Developer/CoreSimulator/Caches` (regenerable dyld caches) that needs an interactive sudo to clear.

enricobuehler added 1 commit 2026-09-01 01:54:52 +00:00

fix(ci): unbreak the main gates — clippy checked_div, isolate docs ... 889cf78d57

The 1.96 clippy's manual_checked_ops fires on mu-smoke's guarded
average division, and the docs drift gate flags the new
PUNKTFUNK_GAMESCOPE_ISOLATE knob as undocumented. Rewrite the average
as checked_div and give the knob its configuration.md row.

enricobuehler merged commit 63a0164442 into main 2026-09-01 09:51:42 +00:00

enricobuehler deleted branch fix/ci-main-clippy-docs 2026-09-01 09:51:43 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

FernandoMX FlipperDan HitFrostbite bluelightspecial enricobuehler (Enrico Bühler) kszlim luxus nannku neoney sonar

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unom/punktfunk#487