fix(ci): the ABI pin, android dead code, windows gamescope compile #455
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: unom/punktfunk#455
Reference in New Issue
Block a user
The touch PRs (#447, #448) merged while their first full CI run's fixes were still in the gates, so main carries the three breaks that run found — one per platform. This is those fixes, two commits, nothing else.
ci / rust:abi_version_is_pinnedstill asserted 27. The v28 bump (the touch capability,punktfunk_connection_host_caps2) arrived in Phase 0 without the pin update the test's own comment demands, and no gate on the branch ever ran punktfunk-core's tests. The pin now says 28, with the v28 line beside it.android / android: cargoNdkClippy rejected the ring's in-stream surface as dead code, and it is right — the Android console holds the ring solely as the editor, soinput,take_command,take_cmds,damage,animating,key, the shell'ssend_cmdandMenuList::animatingare driven only by the desktop overlay. They wearcfg_attr(android, allow(dead_code))(a cfg would cascade into their parameter types' imports), and thehost_actions::{self}import shrinks to the one name every platform uses.windows-client / client(both arches): the twooverlay_focus::gamescope_session()calls T17 and the touch-devices log added compile only on Linux. Both go through a newin_gamescope()that answersfalseoff Linux.Verified: the container gate green with punktfunk-core's tests added (pf-presenter 64, pf-client-core 242, pf-console-ui 227, punktfunk-core 512 — the pin suite in for the first time); clippy
-D warningsfor pf-presenter and the Windows client on the Windows box. The Android lints have no local run (cargo-ndk clippy dies in audiopus's cmake on a Mac); the fixes answer exactly the four errors in the CI log, and this PR's own android job is the check.Two platform breaks from the branch's first full CI run, invisible to the local gates. Android's cargoNdkClippy rejected the ring's in-stream surface as dead code, and it is right: the Android console holds the ring solely as the editor, so `input`, `take_command`, `take_cmds`, `damage`, `animating` and `key` (and the shell's `send_cmd`, and `MenuList::animating`) are driven only by the desktop overlay. They wear `cfg_attr(android, allow(dead_code))` rather than a cfg — cfg'ing them out cascades into their parameter types' imports — and the `host_actions::{self}` import shrinks to the one name every platform uses, with the desktop-only call fully qualified. Windows failed on the two `overlay_focus::gamescope_session()` calls T17 and the touch-devices log added: `overlay_focus` exists only on Linux (there is no gamescope to be inside anywhere else). Both go through a new `in_gamescope()` that answers `false` off Linux. Verified: the container gate green (64 / 242 / 227); clippy `-D warnings` for pf-presenter and the Windows client on the Windows box. The Android lints have no local run (cargo-ndk clippy dies in audiopus's cmake on a Mac) — the fixes answer exactly the four errors in the CI log, and CI is the check.