unom/punktfunk
8
0
Fork 2
Code Issues 15 Pull Requests Actions 1 Packages Projects 1 Releases 54 Wiki Activity

Virtual displays: the Streamed-screen and session⇄game cards showed on both tabs — they join the Configuration tab #353

Merged
enricobuehler merged 1 commits from worktree-displays-tab-dup into main 2026-08-20 06:38:10 +00:00
Conversation 0 Commits 1 Files Changed 2
+25 -6
enricobuehler commented 2026-08-20 06:34:27 +00:00
Owner
Copy Link
Copy Source

The Virtual displays page tabs only the policy form and the live list; the Streamed screen and When a game or a session ends cards sat below the tab shell, so they rendered identically under either tab. Standing on one tab, everything below the first card looked like the other tab's content leaking through — reported as "the live display tab contents are duplicated in the configuration tab".

Both cards are policy surfaces, so they now ride inside the Configuration tab as siblings of the config card (threaded through DisplaySection/DisplayTabs as a node, keeping the tab shell presentational for the Storybook story). The Live displays tab is now only the live list + arrangement editor.

Verified in a headless-browser pass against a mocked management API: Configuration tab renders all three cards exactly as before, Live tab renders only the live content, and the inactive pane stays unmounted.

User-facing fact changed? n/a — page layout only; no docs-site page states where these cards sit.

The Virtual displays page tabs only the policy form and the live list; the **Streamed screen** and **When a game or a session ends** cards sat *below* the tab shell, so they rendered identically under either tab. Standing on one tab, everything below the first card looked like the other tab's content leaking through — reported as "the live display tab contents are duplicated in the configuration tab". Both cards are policy surfaces, so they now ride **inside** the Configuration tab as siblings of the config card (threaded through `DisplaySection`/`DisplayTabs` as a node, keeping the tab shell presentational for the Storybook story). The Live displays tab is now only the live list + arrangement editor. Verified in a headless-browser pass against a mocked management API: Configuration tab renders all three cards exactly as before, Live tab renders only the live content, and the inactive pane stays unmounted. **User-facing fact changed?** n/a — page layout only; no docs-site page states where these cards sit.
enricobuehler added 1 commit 2026-08-20 06:34:30 +00:00
fix(web): the Virtual displays page's trailing cards join the Configuration tab
ci / bun-nix (pull_request) Successful in 28s
Details
ci / docs-drift (pull_request) Successful in 1m1s
Details
ci / web (pull_request) Successful in 1m23s
Details
ci / rust-arm64 (pull_request) Successful in 2m3s
Details
ci / docs-site (pull_request) Failing after 11m15s
Details
ci / rust (pull_request) Successful in 20m0s
Details
e473a4be7b 
The Streamed screen and session-game lifetime cards sat BELOW the tab
shell, so they rendered on both tabs — from the Live displays tab the
page read as the Configuration tab's content duplicated (reported the
other way round, same sight). Both are policy surfaces, so they ride
inside the Configuration tab as siblings of the config card; the Live
tab is now only the live list + arrangement.
enricobuehler scheduled this pull request to auto merge when all checks succeed 2026-08-20 06:38:06 +00:00
enricobuehler merged commit d7fa5847f1 into main 2026-08-20 06:38:10 +00:00
enricobuehler deleted branch worktree-displays-tab-dup 2026-08-20 06:38:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
FernandoMX HitFrostbite enricobuehler (Enrico Bühler) kszlim luxus nannku neoney sassycrown
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unom/punktfunk#353