unom/punktfunk
8
0
Fork 2
Code Issues 2 Pull Requests 1 Actions 6 Packages Projects Releases 52 Wiki Activity

Every device pending approval was called "This device" — the C ABI connect had no name parameter #243

Merged
enricobuehler merged 1 commits from worktree-pairing-friendly-device-name into main 2026-08-15 08:42:55 +00:00
Conversation 0 Commits 1 Files Changed 17
+379 -48
1 Commits
Author SHA1 Message Date
enricobuehler 8ae524d801 fix(pairing): every device pending approval was called "This device"
ci / bun-nix (pull_request) Successful in 1m32s
Details
ci / rust-arm64 (pull_request) Successful in 1m49s
Details
apple / swift (pull_request) Successful in 2m8s
Details
apple / distribute (pull_request) Skipped
Details
apple / screenshots (pull_request) Skipped
Details
windows-client / client (arm64, --no-default-features, aarch64-pc-windows-msvc, C:\t-a64) (pull_request) Successful in 3m29s
Details
ci / web (pull_request) Successful in 4m1s
Details
ci / docs-site (pull_request) Successful in 4m6s
Details
ci / rust (pull_request) Successful in 7m8s
Details
windows-client / client (x64, , x86_64-pc-windows-msvc, C:\t) (pull_request) Successful in 6m44s
Details
android / android (pull_request) Successful in 15m39s
Details 
The web console shows exactly what the host was told, and the host was told
"This device" by every Apple client — so the outstanding-pairings view and the
approve dialog listed identical rows for an iPad, an Apple TV and a Mac.

The name rides `Hello::name`, which embedders fill from `client::device_name()`.
That resolves `COMPUTERNAME` (Windows-only) then `HOSTNAME` (a shell variable
never exported into a launchd-started process), and its last resort was the
literal "This device". No Apple GUI app has either variable, and the C ABI had
no device-name parameter for one to pass a better answer through, so every
Apple device fell through to the placeholder. Linux (/etc/hostname) and Windows
were unaffected; Android sent `Build.MODEL`, which names the product rather than
the unit — two of the same tablet were still indistinguishable.

- core: `punktfunk_connect_ex10` = `ex9` + `device_name` (C ABI v21, no wire
  change — `ex9` keeps its signature and passes a null name for the old
  default). Truncated to `HELLO_NAME_MAX` on a character boundary, since
  slicing a multi-byte name mid-scalar panics.
- core: `device_name()` falls back to `gethostname()` before the placeholder,
  so an embedder that passes nothing still gets a real name.
- apple: `DeviceName.current` (`Host.localizedName` / `UIDevice.current.name`,
  falling back to the hostname when 16+ answers with the bare model) is sent on
  connect, and the two pairing sheets plus the ceremony now read that one source
  instead of three separate literals.
- android: `Settings.Global.DEVICE_NAME` — the name the user typed in Settings —
  ahead of `Build.MODEL`. The "approve this device" prompt quotes the same
  string the connect knocks with, so it can't send the user looking for a row
  the console does not show.
- web: the approve dialog names the device and its fingerprint. A pre-filled
  field is editable text, not a statement of which knock is being approved.
 2026-08-15 01:05:15 +02:00