The mgmt-port learn landed without its Windows half — restore the three missing pieces #241

Merged

enricobuehler merged 1 commits from worktree-windows-client-mgmt-port-fix into main 2026-08-14 22:23:58 +00:00

Conversation 0 Commits 1 Files Changed 5

+17 -2

enricobuehler commented 2026-08-14 22:14:08 +00:00

Owner

Copy Link

Copy Source

Main's windows-client build has been red since #230 merged: 99eb679c wired the learned management port through every client and its own message records the hole — "NOT verified: the Windows client (192.168.1.133 unreachable)". The Windows usage sites landed; the three definitions they lean on existed nowhere.

• clients/windows/src/trust.rs re-exports core's trust surface — learn_mgmt_port was added to core but never joined the re-export list (hosts.rs:729, E0425).
• The Windows shell's own mDNS browser ("ported verbatim from the GTK client") never learned the mgmt TXT that pf_client_core::discovery already parses — DiscoveredHost gains the field, parsed the same way (hosts.rs:725/727/1062, E0609).
• HostTarget never carried the port, so the Target the shell builds from a ConnectPlan had nothing to read (mod.rs:414, E0609). Wired From<&KnownHost> like mac; the two spawn-path literals stay None — a spawn plan never fetches the library, and each shell resolves the port itself at its fetch site.

The windows-client job on this PR is the verification 99eb679c could not run.

Main's `windows-client` build has been red since #230 merged: `99eb679c` wired the learned management port through every client and its own message records the hole — "NOT verified: the Windows client (192.168.1.133 unreachable)". The Windows usage sites landed; the three definitions they lean on existed nowhere. * `clients/windows/src/trust.rs` re-exports core's trust surface — `learn_mgmt_port` was added to core but never joined the re-export list (`hosts.rs:729`, E0425). * The Windows shell's own mDNS browser ("ported verbatim from the GTK client") never learned the `mgmt` TXT that `pf_client_core::discovery` already parses — `DiscoveredHost` gains the field, parsed the same way (`hosts.rs:725/727/1062`, E0609). * `HostTarget` never carried the port, so the `Target` the shell builds from a `ConnectPlan` had nothing to read (`mod.rs:414`, E0609). Wired `From<&KnownHost>` like `mac`; the two spawn-path literals stay `None` — a spawn plan never fetches the library, and each shell resolves the port itself at its fetch site. The `windows-client` job on this PR is the verification `99eb679c` could not run.

enricobuehler added 1 commit 2026-08-14 22:14:10 +00:00

fix(clients): the mgmt-port learn landed without its Windows half — restore the three missing pieces ... 2b066b3e11

99eb679c wired the learned management port through every client, and its own commit message
records the hole: 'NOT verified: the Windows client (192.168.1.133 unreachable)'. The Windows
shell's usage sites landed, but the three definitions they lean on did not exist anywhere, so
main's windows-client build has been red since the merge of #230:

* clients/windows/src/trust.rs re-exports core's trust surface — learn_mgmt_port was added to
  core but never joined the re-export list (hosts.rs:729, E0425).
* The Windows shell's own mDNS browser (discovery.rs, 'ported verbatim from the GTK client')
  never learned the mgmt TXT that pf_client_core::discovery already parses — DiscoveredHost
  gains the field, parsed the same way (hosts.rs:725/727/1062, E0609).
* HostTarget ('the host a plan dials') never carried the port, so the Target the shell builds
  from a ConnectPlan had nothing to read (mod.rs:414, E0609). Wired From<&KnownHost> like mac;
  the two spawn-path literals stay None — a spawn plan never fetches the library, and each
  shell resolves the port itself at its fetch site.

cargo fmt --all --check clean. pf-client-core/linux/session compile via the rust CI job; the
windows-client job on this PR is the verification 99eb679c could not run.

enricobuehler merged commit 8c6099da2a into main 2026-08-14 22:23:58 +00:00

enricobuehler deleted branch worktree-windows-client-mgmt-port-fix 2026-08-14 22:24:00 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

FernandoMX enricobuehler (Enrico Bühler) kszlim nannku neoney sassycrown

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unom/punktfunk#241