The plugin runner was located by FHS path only, so NixOS never found it #207

Merged

enricobuehler merged 3 commits from worktree-nix-plugin-runner-resolve into main 2026-08-13 20:10:16 +00:00

Conversation 0 Commits 3 Files Changed 8

+363 -42

3 Commits

Author	SHA1	Message	Date
enricobuehler	c12476736d	docs(changelog): v0.28.0 was tagged, so these fixes belong in a v0.28.1 section ... The branch is based on the commit v0.28.0 points at, so writing the NixOS runner fix into that section would have credited a released version with a change it does not contain. Moved to a fresh `v0.28.1 — in development` section, matching how the v0.28.0 cycle was kept (a `— in development` heading the release commit renames).	2026-08-13 20:40:02 +02:00
enricobuehler	5bcee83c34	test: /bin/true and /bin/false do not exist on NixOS ... Two tests hardcoded absolute paths into /bin, which on NixOS holds only `sh` — so `cargo test` failed there for reasons that had nothing to do with the code under test. `gamelease` only needs a process that exits quickly and successfully, so the bare name resolved through PATH is exactly right. `pyrowave_remote` cannot use a bare name: `spawn_link` pins the binary with `PinnedExe::open`, so a name that PATH would have resolved fails the OPEN instead — which takes the spawn-failure rung rather than the handshake rung the test exists to exercise. It resolves a real path off PATH first, keeping the test on the rung it names.	2026-08-13 20:30:33 +02:00
enricobuehler	4ebe7d1185	fix(host): the plugin runner was located by FHS path only, so NixOS never found it ... On NixOS every plugin PACKAGE op failed with "the plugin runner isn't installed" on a box where the runner was installed, enabled and running. `runner_command()` checked FHS locations exclusively — /usr/bin, the /usr/lib + /usr/share pair behind it, and the ~/.local mirror the SteamOS installer lays down. Nix ships punktfunk-scripting as a derivation of its OWN, so its wrapper is neither beside the host binary nor anywhere under /usr, and no rung could ever match. Service ops go through systemd and were unaffected, which is what made it read as arbitrary: `plugins status` said running/enabled while `plugins add` said not installed. Resolution now matches punktfunk-encode-worker's: PUNKTFUNK_SCRIPTING -> beside the host binary -> PATH -> /usr -> ~/.local. PATH is the rung Nix lands on. The /usr rungs stay AFTER it rather than being dropped, because a systemd unit's PATH need not include /usr/bin. As with the encode worker the env override is deliberately not existence-checked — a named path that is wrong should fail naming itself, not fall through to some other runner. Lifted into a pure injected function so the whole table is testable, which is also how the regression is pinned: removing the PATH rung fails the NixOS row specifically. Second half, and the reason the Rust change alone would not have fixed the console: the NixOS module now puts the runner on the HOST UNIT's `path`. The console installs plugins from inside the host service, whose PATH is exactly that unit list — `environment.systemPackages` only ever covered an operator's interactive shell. Without it the CLI would have been fixed and the console would not. module-check.nix gains both the positive and the negative assertion, so CI's `nix flake check --no-build` holds the property. The error text named only apt and SteamOS; it now names NixOS and the override. The ~/.local/bin symlink workaround is no longer needed.	2026-08-13 20:27:26 +02:00