The six built-in library scanners become plugins — M6/WP6.4 #199

Merged

enricobuehler merged 3 commits from worktree-remove-builtin-scanners into main 2026-08-13 15:19:44 +00:00

Conversation 0 Commits 3 Files Changed 24

+411 -2429

3 Commits

Author	SHA1	Message	Date
enricobuehler	362d532d25	chore(api): regenerate openapi.json for the scanner-removal doc changes ... `mgmt::tests::openapi_document_is_complete_and_checked_in` compares the served document against the checked-in snapshot, so the endpoint doc edits in the scanner removal made it stale and failed `ci / rust`. Regenerated with `cargo run -p punktfunk-host -- openapi > api/openapi.json`. The diff is 11 lines, all descriptions — no path, operationId or schema shape moved. In particular `SourceOrigin` still enumerates ["builtin", "plugin"]: the variant was kept deliberately so the console, which ships as its own package and drives an N-1 host that still reports builtin sources, does not have its generated union narrowed out from under that pairing.	2026-08-13 17:06:15 +02:00
enricobuehler	e568513f74	fix(web): retry the console image's dependency install once ... A single failed tarball kills `bun install` and takes the whole image build with it. Seen in CI as: error: Fail extracting tarball for "@rolldown/binding-linux-x64-musl" — a 7.7 MB optional binding that bun fetches on any linux-x64 host (the lockfile records `os`/`cpu` but no libc, so the musl and glibc bindings are equally eligible) and that had arrived truncated. The lockfile is NOT at fault, which is worth recording because it is the obvious suspect: `bun install --frozen-lockfile` accepts it, regenerating it with bun 1.3.14 — the version in the failing log — is byte-identical, the tarball downloads and extracts cleanly, and this exact layer builds green for `--platform linux/amd64` with `--no-cache`. So this is a transient-download guard, not a lockfile fix: two attempts with a pause, then fail for real. It recovers a truncated download and deliberately does NOT paper over a runner that is out of disk, which fails identically every time.	2026-08-13 16:52:12 +02:00
enricobuehler	7403450a8d	feat(host/library)!: the six built-in scanners become plugins — M6/WP6.4 ... The host no longer scans any launcher itself. `library/{steam,epic,gog,heroic, lutris,xbox}.rs` and the `scanner_defs()` table are gone; `GET /library/scanners` now lists exactly what the operator installed, every row `origin: "plugin"`. This is the end of the migration whose bridge half shipped in v0.26.0. The plugins have been published and index-pinned since 2026-08-08, so the replacement has been in the field for the whole bridge window. A host with no library plugins installed has an empty grid — that is the upgrade note. The console's one-click install per source (the D9 nudge) is unchanged and still never auto-installs. Nothing about a title changes when its plugin takes over, and that is why this could be a deletion rather than a rewrite: a plugin CLAIMS its store (D2), and a claimed entry surfaces under the deterministic `<store>:<external_id>` id the scanner used to produce. Entry ids, GameStream FNV-1a app ids, client art caches, Moonlight pins, the per-source toggles and the per-entry hides all key on that id and none of them move. `library-scanners.json` keeps its name, shape and contents: an operator who had `steam` off still has it off, with no migration. Kept deliberately: * `launch.rs` in full. Launch is host-owned by design D1 — a plugin publishes a validated value, the host builds the command — so every typed kind survives. `xbox_pfn()` MOVED here out of the deleted `xbox.rs`: resolving a package Identity to its PackageFamilyName needs `AppRepository` enumeration, readable by the host (LocalSystem) and denied to the plugin runner (LocalService). That measured asymmetry is the whole reason the `xbox` launch kind exists, so the resolver is launch vocabulary, not scanner vocabulary. * `SourceOrigin::Builtin`. No host build emits it, but the console ships as its own package and drives an N-1 host that still does, so the variant stays in the schema and the console keeps its `builtin` handling. * A store-label table, so a source row does not rename itself from "Steam" to `steam` the day its plugin takes over. Removed with the scanners: the background cover-art warmer and its on-disk cache (they existed only for GOG and Xbox, the two sources that had to ask a network catalog what a cover was — a plugin resolves art while it scans), the legacy `steam:` branch of the art proxy, and `GameMeta::pc()`. The host now makes no outbound HTTP request to build a library at all. Dependency audit, as WP6.4 required: `rusqlite` (with its bundled, cc-compiled SQLite) and `roxmltree` leave the graph — verified no other users. `winreg` stays: `launch.rs`, `procscan/windows.rs` and two `audio/windows/` modules need it. `base64`/`ureq` stay, exactly as the plan predicted. A stale `library-art-cache.json` from an older host is ignored, not migrated.	2026-08-13 16:51:19 +02:00