unom/punktfunk
6
0
Fork 1
Code Issues 3 Pull Requests 1 Actions 2 Packages Projects Releases 48 Wiki Activity

fix(ci): gate C counts comments, and a comment named the env mutators verbatim #183

Merged
enricobuehler merged 1 commits from fix/gate-c-comment-token into main 2026-08-12 16:57:41 +00:00
Conversation 0 Commits 1 Files Changed 1
+6 -4
enricobuehler commented 2026-08-12 16:57:24 +00:00
Owner
Copy Link
Copy Source

Main has been red on the rust job since #181: 55a3d8b9 added the edition-2024 lint-level rationale to the session bin's header, naming std::env::set_var/remove_var verbatim — and gate C's grep counts comments by contract, so the file hit 5 mentions against its 4-call-site baseline (every later step skipped).

Reword the comment rather than raising the baseline: a baseline of 5 with a comment folded in would hide the next real call site. The four SAFETY-commented call sites are untouched.

Verified locally: scripts/ci/check-unsafe-hygiene.sh clean, cargo fmt --all --check clean.

Main has been red on the `rust` job since #181: `55a3d8b9` added the edition-2024 lint-level rationale to the session bin's header, naming `std::env::set_var`/`remove_var` verbatim — and gate C's grep counts comments by contract, so the file hit 5 mentions against its 4-call-site baseline (every later step skipped). Reword the comment rather than raising the baseline: a baseline of 5 with a comment folded in would hide the next real call site. The four SAFETY-commented call sites are untouched. Verified locally: `scripts/ci/check-unsafe-hygiene.sh` clean, `cargo fmt --all --check` clean.
enricobuehler added 1 commit 2026-08-12 16:57:25 +00:00
fix(ci): gate C counts comments, and a comment named the env mutators verbatim
ci / rust-arm64 (pull_request) Successful in 1m50s
Details
ci / docs-site (pull_request) Successful in 1m33s
Details
ci / web (pull_request) Successful in 2m30s
Details
ci / rust (pull_request) Successful in 14m12s
Details
windows / build (aarch64-pc-windows-msvc) (pull_request) Successful in 1m21s
Details
windows / build (x86_64-pc-windows-msvc) (pull_request) Successful in 2m32s
Details
ci / bun-nix (pull_request) Failing after 13m41s
Details
6f81ec24ba 
55a3d8b9 (#181) added the edition-2024 lint-level rationale to the session
bin's header naming std::env::set_var/remove_var — gate C's grep counts
comments by contract, so main went red at 5 mentions against the 4-call-site
baseline. Reword the comment instead of raising the baseline: a baseline of 5
with one comment inside would hide the next real call site.

Verified: scripts/ci/check-unsafe-hygiene.sh clean, cargo fmt clean.
enricobuehler merged commit d7430fe2bd into main 2026-08-12 16:57:41 +00:00
enricobuehler deleted branch fix/gate-c-comment-token 2026-08-12 16:57:46 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
FernandoMX enricobuehler (Enrico Bühler) kszlim nannku neoney sassycrown
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unom/punktfunk#183