fix(windows): opt-in pad-driver file logs + size-capped service log rotation

Two disk-write fixes:

- pf-xusb/pf-dualsense no longer write C:\Users\Public\pf*-driver.log
  unconditionally — the file log is now opt-in (debug builds, or the
  PFXUSB_DEBUG_LOG / PFDS_DEBUG_LOG system env var), mirroring the audit-§4.4
  fix pf-vdisplay already got: a release driver never writes the world-writable
  Public file (info-leak/DoS surface), and the per-report OUTPUT/SET_STATE hex
  dumps stop being a sustained per-rumble disk-write path during gameplay.
  OutputDebugStringA stays unconditional; the host's driver-silence WARN and
  the gamepad-driver-health failure-mode table now say the log is opt-in.

- service.log/host.log get one-generation rotation: at each (re)open a file
  over 10 MB is renamed to .old, so a crash-restart loop or a RUST_LOG=debug
  left in host.env can't grow the append-forever logs without bound. Rotation
  runs only before an open (never under a live appender — host.log's handle
  lacks FILE_SHARE_DELETE, so a racing rename harmlessly fails).

Windows CI compile/clippy pending (drivers workspace + host are not
Linux-cross-checkable); rides along with the next pad-driver redeploy.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
2026-07-03 14:03:32 +00:00
parent 1320e3dc66
commit efb1ba26d7
6 changed files with 97 additions and 16 deletions
@@ -534,7 +534,9 @@ impl DriverAttach {
driver_log = self.driver_log,
"gamepad driver has not attached to the shared section — the virtual pad exists but no \
driver is serving it (games will not see it); an old (pre-sealed-channel) driver also \
reads as not-attached: update with punktfunk-host.exe driver install --gamepad"
reads as not-attached: update with punktfunk-host.exe driver install --gamepad \
(driver_log is only written by debug driver builds, or with the PFXUSB_DEBUG_LOG / \
PFDS_DEBUG_LOG system env var set + the device restarted)"
);
}
}
+26 -3
View File
@@ -130,6 +130,23 @@ fn host_log_path() -> PathBuf {
dir.join("host.log")
}
/// One-generation size cap for the append-forever logs: at each (re)open, a file over this size is
/// renamed to `<name>.old` (replacing the previous generation) — so a crash-restart loop or a
/// `RUST_LOG=debug` left in host.env can't grow them without bound.
const LOG_ROTATE_BYTES: u64 = 10 * 1024 * 1024;
/// Rotate `path` to `path.old` when it has outgrown [`LOG_ROTATE_BYTES`]. Only called right before
/// an open (service start for service.log, each host (re)launch for host.log) — never while a live
/// handle appends: renaming under an appender would silently redirect its writes into the `.old`
/// file. Best-effort; a failed rename just means one more un-rotated run.
fn rotate_if_large(path: &std::path::Path) {
if std::fs::metadata(path).is_ok_and(|m| m.len() >= LOG_ROTATE_BYTES) {
let mut old = path.as_os_str().to_owned();
old.push(".old");
let _ = std::fs::rename(path, std::path::Path::new(&old));
}
}
/// Initialise tracing to the service log file (the SCM gives the service no console/stderr). Falls
/// back to stderr if the file can't be opened. Called from `main()` only for `service run`.
/// Also tees into the in-memory log ring (`log_capture`), like the stderr path in `main()` — the
@@ -140,10 +157,12 @@ pub fn init_file_logging(filter: tracing_subscriber::EnvFilter) {
use tracing_subscriber::Layer;
let ring =
crate::log_capture::RingLayer.with_filter(tracing_subscriber::filter::LevelFilter::DEBUG);
let log_path = service_log_path();
rotate_if_large(&log_path);
match std::fs::OpenOptions::new()
.create(true)
.append(true)
.open(service_log_path())
.open(log_path)
{
Ok(file) => {
tracing_subscriber::registry()
@@ -549,8 +568,12 @@ unsafe fn spawn_host(
let _ = DestroyEnvironmentBlock(env_block);
}
// 3) Redirect the host's stdout+stderr to host.log (inheritable handle).
let log = open_log_handle(&host_log_path())?;
// 3) Redirect the host's stdout+stderr to host.log (inheritable handle). The previous child has
// exited by the time the supervise loop relaunches, so its handle can't be live here — safe
// to rotate. (A leaked orphan's handle lacks FILE_SHARE_DELETE, so the rename just fails.)
let host_log = host_log_path();
rotate_if_large(&host_log);
let log = open_log_handle(&host_log)?;
let mut si = STARTUPINFOW {
cb: std::mem::size_of::<STARTUPINFOW>() as u32,