unom/punktfunk
6
0
Fork 1
Code Issues 3 Pull Requests 2 Actions 17 Packages Projects Releases 45 Wiki Activity

fix(host/audio): capture endpoints get the device format only

Browse Source 
Live bisect on a fresh endpoint: the mix/host format keys are
RENDER-engine properties — stamped onto a capture endpoint they broke its
shared-mode graph (IsFormatSupported reported 2ch/48k OK while Initialize
failed 0x88890008 on a once-stamped fresh endpoint; unstamped it opened
fine, S3). The capture now gets ONLY the device-format key — the knob
mmsys.cpl itself writes — declaring the stereo the pins actually accept.
This commit is contained in:
enricobuehler
2026-08-07 16:49:15 +02:00
parent 8c274d6256
commit 52cd42e911
1 changed files with 32 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/punktfunk-host/src/audio/windows/minted.rs
+32 -31
View File
@@ -351,38 +351,39 @@ fn stamp_identity(endpoint_id: &str, role: Role, capture: bool) {
value: pe::StampValue::Str("Punktfunk"),
},
];
// The mic pair gets ONE coherent stereo format set on BOTH endpoints, in the exact
// PCM16-device/float-mix split the pad program's stamp bisect proved the driver accepts
// (its first "unopenable endpoint" and "format can't be changed" verdicts were both
// incoherent-stamp artifacts — this branch re-derived the same false verdicts before the
// pad recipe was re-applied). Both sides identical: the driver moves one stream between
// the two endpoints, and the octave-low voice was the two sides DISAGREEING (stereo
// render default vs mono capture default). `capture` steers nothing today — kept so a
// per-direction split stays one edit away.
let _ = capture;
// The mic pair runs STEREO 48 kHz on both sides — the pins accept it (micpins), and the
// octave-low voice was the two sides DISAGREEING (stereo render default vs mono capture
// default). The stamp sets differ per direction, bisected live:
// * RENDER: the pad program's proven PCM16-device/float-mix split (its own bisect).
// * CAPTURE: the DEVICE format ONLY — the mix/host keys are RENDER-engine properties,
// and stamping them onto a capture endpoint broke its shared-mode graph
// (IsFormatSupported said 2ch/48k OK while Initialize failed 0x88890008 on a fresh,
// once-stamped endpoint; unstamped it opened fine).
if role == Role::Mic {
stamps.extend([
pe::Stamp {
label: "device-format",
key: pe::PKEY_DEVICE_FORMAT,
value: pe::StampValue::Format(&WFX_PCM16_2CH_48K),
},
pe::Stamp {
label: "mix-format-2",
key: pe::PKEY_MIX_FORMAT_2,
value: pe::StampValue::Format(&WFX_F32_2CH_48K),
},
pe::Stamp {
label: "mix-format-3",
key: pe::PKEY_MIX_FORMAT_3,
value: pe::StampValue::Format(&WFX_F32_2CH_48K),
},
pe::Stamp {
label: "host-format",
key: pe::PKEY_HOST_FORMAT,
value: pe::StampValue::Format(&WFX_F32_2CH_48K),
},
]);
stamps.push(pe::Stamp {
label: "device-format",
key: pe::PKEY_DEVICE_FORMAT,
value: pe::StampValue::Format(&WFX_PCM16_2CH_48K),
});
if !capture {
stamps.extend([
pe::Stamp {
label: "mix-format-2",
key: pe::PKEY_MIX_FORMAT_2,
value: pe::StampValue::Format(&WFX_F32_2CH_48K),
},
pe::Stamp {
label: "mix-format-3",
key: pe::PKEY_MIX_FORMAT_3,
value: pe::StampValue::Format(&WFX_F32_2CH_48K),
},
pe::Stamp {
label: "host-format",
key: pe::PKEY_HOST_FORMAT,
value: pe::StampValue::Format(&WFX_F32_2CH_48K),
},
]);
}
}
// Steady state (every boot after the first): the names are already served — no writes,
// no settle sleeps.