refactor: workspace restructure — contract package + pure domain ported, tests green

- bun workspaces: contract/ (Schemas = source of truth: config raw↔resolved, domain DTOs, HttpApi contract, API errors) + plugin/ + ui/ - pure domain moved src/{engine,art}→plugin/src/{domain,art}, types now imported from @rom-manager/contract and @punktfunk/plugin-kit/wire (the hand-copied wire.ts dies), loggers injected instead of module-global - ui.* and devEntry dropped from the config shape (standalone server is gone; stale keys tolerated on decode, dropped by the next save) - all 48 domain tests ported and green BEFORE any Effect wiring Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-20 18:54:38 +02:00
parent e78df91925
commit d6cf5f3d36
30 changed files with 1938 additions and 181 deletions
@@ -0,0 +1,137 @@
+import { describe, expect, test } from "bun:test";
+import { resolveConfig } from "@rom-manager/contract";
+import type { DetectedEmulator } from "../src/domain/emulators.js";
+import { computeDesired } from "../src/domain/reconcile.js";
+import type { RomCandidate } from "../src/domain/scanner.js";
+import type { ArtVerdict } from "../src/art/provider.js";
+
+const RA: DetectedEmulator = {
+	id: "retroarch",
+	name: "RetroArch",
+	template: "{exe} -f -L {core} {rom}",
+	supportsArchives: true,
+	exeToken: "'/usr/bin/retroarch'",
+	via: "path",
+	coresDir: "/cores",
+	cores: ["snes9x"],
+};
+
+const cand = (rel: string, over: Partial<RomCandidate> = {}): RomCandidate => ({
+	platform: "snes",
+	rootDir: "/roms/snes",
+	absPath: `/roms/snes/${rel}`,
+	relPath: rel,
+	ext: ".sfc",
+	stem: rel.replace(/\.[^.]+$/, ""),
+	isArchive: false,
+	...over,
+});
+
+const base = { roots: [{ dir: "/roms/snes", platform: "snes" }] };
+const run = (
+	raw: Record<string, unknown>,
+	scan: RomCandidate[],
+	art: Record<string, ArtVerdict> = {},
+	detected = [RA],
+) =>
+	computeDesired({
+		config: resolveConfig({ ...base, ...raw }),
+		scan,
+		detected,
+		art,
+		os: "linux",
+	});
+
+describe("computeDesired", () => {
+	test("produces a quoted launch command with the resolved core path", () => {
+		const { entries } = run({}, [cand("Chrono Trigger (USA).sfc")]);
+		expect(entries).toHaveLength(1);
+		expect(entries[0]).toMatchObject({
+			external_id: "snes/Chrono Trigger (USA).sfc",
+			title: "Chrono Trigger",
+			launch: {
+				kind: "command",
+				value:
+					"'/usr/bin/retroarch' -f -L '/cores/snes9x_libretro.so' '/roms/snes/Chrono Trigger (USA).sfc'",
+			},
+		});
+	});
+
+	test("per-game exclude drops the entry", () => {
+		const { entries } = run(
+			{ gameOverrides: { "snes/A.sfc": { exclude: true } } },
+			[cand("A.sfc"), cand("B.sfc")],
+		);
+		expect(entries.map((e) => e.external_id)).toEqual(["snes/B.sfc"]);
+	});
+
+	test("an undetected emulator is skipped with a reason", () => {
+		const { entries, report } = run({}, [cand("A.sfc")], {}, []);
+		expect(entries).toHaveLength(0);
+		expect(report.skipped[0]?.reason).toContain("not detected");
+	});
+
+	test("region dedupe keeps the preferred release", () => {
+		const { entries, report } = run({ sync: { dedupeRegions: ["snes"] } }, [
+			cand("Sonic (USA).sfc"),
+			cand("Sonic (Europe).sfc"),
+		]);
+		expect(entries.map((e) => e.external_id)).toEqual(["snes/Sonic (USA).sfc"]);
+		expect(report.skipped.some((s) => s.reason.includes("deduped"))).toBe(true);
+	});
+
+	test("attaches cached artwork, keyed by external_id", () => {
+		const art = {
+			"snes/A.sfc": {
+				art: { portrait: "http://x/p.png", hero: "http://x/h.png" },
+				provider: "steamgriddb:ab",
+				matcher: 1,
+			},
+		};
+		const { entries } = run({}, [cand("A.sfc")], art);
+		expect(entries[0]?.art).toEqual({
+			portrait: "http://x/p.png",
+			hero: "http://x/h.png",
+		});
+	});
+
+	test("per-game art override wins on portrait but keeps other cached art", () => {
+		const art = {
+			"snes/A.sfc": {
+				art: { portrait: "http://x/p.png", hero: "http://x/h.png" },
+				provider: "p",
+				matcher: 1,
+			},
+		};
+		const { entries } = run(
+			{ gameOverrides: { "snes/A.sfc": { art: "http://o/p.png" } } },
+			[cand("A.sfc")],
+			art,
+		);
+		expect(entries[0]?.art).toEqual({
+			portrait: "http://o/p.png",
+			hero: "http://x/h.png",
+		});
+	});
+
+	test("archive gating skips a zip when the emulator can't read archives", () => {
+		const noArc = { ...RA, supportsArchives: false };
+		const { entries, report } = run(
+			{},
+			[cand("A.zip", { ext: ".zip", isArchive: true })],
+			{},
+			[noArc],
+		);
+		expect(entries).toHaveLength(0);
+		expect(report.skipped[0]?.reason).toContain("archive");
+	});
+
+	test("scale guard truncates deterministically and reports it", () => {
+		const { entries, report } = run({ sync: { maxEntries: 1 } }, [
+			cand("B.sfc"),
+			cand("A.sfc"),
+		]);
+		expect(entries.map((e) => e.external_id)).toEqual(["snes/A.sfc"]); // sorted, first kept
+		expect(report.truncated).toBe(1);
+	});
+});