enricobuehler 6de325a6b6 fix(ci): the unsafe lint said warn while CI enforced it as deny, and main went red ...

`unsafe_op_in_unsafe_fn = "warn"` was adopted workspace-wide in 39513528 on the assumption that
`warn` is a soft setting you can clear at leisure. It is not: ci.yml runs `cargo clippy … -D
warnings`, which promotes it to a hard error, so main has failed on EVERY commit since — Linux
`rust` and `rust-arm64` both dying on `pf-client-core` with 70 E0133 errors, and windows-host.yml
alongside them. A lint level that understates its own severity is worse than a strict one, so this
states what CI already does — `deny` — and writes the exemptions down instead.

Fourteen GPU/FFI backend files take `#![allow(unsafe_op_in_unsafe_fn)]`, each with its reason and
the workspace Cargo.toml carrying the argument in full. They are not "not done yet": measured
across them, 64% of the sites are a single third-party FFI call (ash, pyrowave-sys, libav, the
NVENC/AMF entry tables), and of the 44 `unsafe fn`s only 4 have a body containing no unsafe
operation at all. Since pf-encode also denies `undocumented_unsafe_blocks`, narrowing them means a
hand-written SAFETY comment per line that could only restate the signature — the exact noise that
made `unsafe` stop meaning anything here before. Everything else stays at zero and enforced, and
each allow is removable on its own terms.

Two smaller things this had to clear, both invisible to the job that would have caught them:

- `service.rs`: `undocumented_unsafe_blocks` wants the proof on EACH block, and a comment covering
  a group of consecutive `unsafe` statements only credits the first — so the two `OwnedHandle`
  wraps became their own statements. Windows-gated, so only the .47 gate sees it. 37a42078 fixed
  the same class of failure in pf-frame/dxgi.rs concurrently; that fix is taken as-is here.
- `clients/linux/ui_settings.rs`: `show`'s deletion left its doc comment stranded on `show_scoped`,
  which silently merged two unrelated doc blocks onto one fn. Removed.

Verified by running the real CI commands, not proxies: on .21 fmt + `clippy --workspace
--all-targets -- -D warnings` + the feature-gated `-p pf-encode --features
nvenc,vulkan-encode,pyrowave` + build + test, all rc=0; on the Intel box .47 all four
windows-host.yml clippy invocations, all rc=0. The arm64 job lints pf-client-core and
punktfunk-client-linux, both covered here.

2026-07-28 22:32:30 +02:00

..

audio_wasapi.rs

chore: consolidate parallel-session WIP (HOLD — do not push)

2026-07-16 12:42:53 +02:00

audio.rs

feat(client): device-pick plumbing — GPU enumeration + audio endpoint targeting

2026-07-19 19:32:38 +02:00

clipboard.rs

fix(client): clipboard poll cadence was never applied (and CI clippy)

2026-07-19 19:22:24 +02:00

deeplink.rs

feat(client): the punktfunk:// grammar — one parser, one emitter, one vector file

2026-07-28 20:32:32 +02:00

discovery.rs

fix(clients): pin mDNS discovery to IPv4 on every client

2026-07-09 10:57:41 +02:00

gamepad.rs

fix(client/gamepad): honor an explicit controller type — the per-pad arrival was re-declaring the physical pad

2026-07-26 16:56:44 +02:00

keymap.rs

refactor(client): extract UI-agnostic plumbing into pf-client-core (phase 0)

2026-07-07 23:13:16 +02:00

lib.rs

refactor(client): the hardware decoders own their hwdevice ref

2026-07-28 21:31:41 +02:00

library.rs

feat(library): descriptive metadata on every entry — platform, year, genres, and friends

2026-07-26 19:00:30 +02:00

orchestrate.rs

feat(client): the brain layer — one connect plan, one wake machine, one spawn

2026-07-28 20:45:07 +02:00

profiles.rs

feat(client): the punktfunk:// grammar — one parser, one emitter, one vector file

2026-07-28 20:32:32 +02:00

session.rs

feat(client): settings profiles — the override catalog, the one resolver, and the session flag

2026-07-28 20:22:33 +02:00

trust.rs

feat(client): the brain layer — one connect plan, one wake machine, one spawn

2026-07-28 20:45:07 +02:00

video_color.rs

refactor(client-core/W8): split video.rs into flat decoder-backend siblings

2026-07-17 14:06:57 +02:00

video_d3d11.rs

refactor(client): the D3D11VA decoder owns its refs too, and the owner-only fields say so

2026-07-28 21:31:41 +02:00

video_libav.rs

refactor(client): the hardware decoders own their hwdevice ref

2026-07-28 21:31:41 +02:00

video_pyrowave.rs

fix(ci): the unsafe lint said warn while CI enforced it as deny, and main went red

2026-07-28 22:32:30 +02:00

video_software.rs

refactor(client-core/W8): split video.rs into flat decoder-backend siblings

2026-07-17 14:06:57 +02:00

video_vaapi.rs

refactor(client): the D3D11VA decoder owns its refs too, and the owner-only fields say so

2026-07-28 21:31:41 +02:00

video_vulkan.rs

fix(ci): the unsafe lint said warn while CI enforced it as deny, and main went red

2026-07-28 22:32:30 +02:00

video.rs

feat(client/windows): PyroWave decode + surface it in the GUI codec picker

2026-07-19 19:06:06 +02:00

wol.rs

refactor(client): extract UI-agnostic plumbing into pf-client-core (phase 0)

2026-07-07 23:13:16 +02:00