enricobuehler
a85e845255
A pre-release sweep of the management console for two things that no type check
and no diff can catch: primitives that were never @unom/ui's, and animation
that a nested motion parent quietly cancelled.
THE PRESET TILES ALL LANDED ON THE SAME FRAME. @unom/ui's <Section> sets
`delayChildren: stagger(...)`, so a page whose cards are direct descendants of
it staggers for free — which is why every page but one looked right. An
<AnimatedCard> is ALSO a motion element and sets no `delayChildren`, and the
Virtual displays preset tiles are cards nested INSIDE that page's config card,
so that card became their timing group. Measured in a headless browser: the
opacity spread between the first and last tile was 0.00 across the whole
animation (six tiles in lockstep), and is 0.98 now — a ~100 ms cascade matching
the rest of the console. The four hand-rolled copies of the stagger container
collapse into one `<Stagger>` that carries the explanation.
FIVE FILES IMPORTED THE WRONG BUTTON. `@unom/ui/button` exports both a plain
`Button` and the `AnimatedButton` that this console's wrapper re-exports under
the same name — so `import { Button } from "@unom/ui/button"` compiles, renders,
and silently opts out of the mount animation and the hover/tap response.
Displays, SessionGame, GPU, Update and PendingDevices had dead buttons sitting
next to live ones.
THREE PRIMITIVES HAD NO WRAPPER, SO NOBODY REACHED FOR THEM. @unom/ui ships
form/select, form/textarea and form/checkbox; components/ui did not, and the
gap was filled with browser-chrome `<select>`, `<textarea>` and
`<input type="checkbox">` in the add-hook modal and both library forms. Select
needs the same token correction Tabs needed — upstream `text-secondary` is a
text colour, but here `--secondary` is a SURFACE, so the trigger's chevron and
placeholder rendered at near-zero contrast on the card behind them.
The hook timeout also stops accepting a value the host rejects: `min`/`max` on
a controlled `<input type="number">` are decoration (no form validation ever
runs), so 900 went into a field capped at 600 and failed later, at run time.
@unom/ui's InputNumber clamps on blur and lets the field be empty while you
retype instead of snapping to the fallback.
Storybook gains the page that had no story at all — the console's largest
config surface, and the reason this shipped unseen. Its <Card> wrapper is load
bearing: it reproduces the motion nesting that IS the bug.
17 lines
926 B
TypeScript
17 lines
926 B
TypeScript
// The console's numeric field IS @unom/ui's form input-number — the Input with a number's rules
|
|
// layered on: it keeps a local draft while you type (so the field can be EMPTY on the way to a new
|
|
// value), commits only a finite in-range number, and clamps to `min`/`max` on blur.
|
|
//
|
|
// That is not cosmetic. The hand-rolled shape it replaces —
|
|
//
|
|
// <Input type="number" min={1} max={600}
|
|
// onChange={(e) => set({ timeout_s: Number(e.target.value) || 30 })} />
|
|
//
|
|
// — has two defects the shared component doesn't: clearing the field snaps it to the fallback
|
|
// instead of letting you retype, and `min`/`max` are decoration (an `<input>`'s range is only
|
|
// enforced by form validation, which a controlled field like this never runs) — so 900 went
|
|
// straight into a timeout capped at 600.
|
|
//
|
|
// `onChange` hands you a `number`, not an event.
|
|
export { InputNumber } from "@unom/ui/form/input-number";
|