enricobuehler
5219107177
`packaging/windows/drivers/*` has run `deny(unsafe_op_in_unsafe_fn)` +
`deny(clippy::undocumented_unsafe_blocks)` for a while, with `forbid(unsafe_code)`
on the modules that need no unsafe at all. The main workspace had no lint config
whatsoever, so nothing stopped a clean crate from quietly growing an `unsafe`, and
nothing distinguished the handful of genuinely-unsafe lines inside a 600-line
`unsafe fn` from the safe ones surrounding them.
Three things, all mechanical:
* `#![forbid(unsafe_code)]` on the eight crates that already contain zero unsafe
(`pf-driver-proto`, `pf-host-config`, `pf-paths`, the three clean clients, both
tools). These were clean by accident, not by contract; now they are clean by
contract.
* `unsafe_op_in_unsafe_fn = "warn"` workspace-wide. `unsafe fn` states a contract
the CALLER must uphold — it was never meant to switch off checking for the whole
body. Measured fallout is 300 sites on Linux, and they are concentrated: six
files carry all of them, while `punktfunk-core`, `pf-frame`, `pf-clipboard` and
`pf-vdisplay` are already at zero. `warn` (not `deny`) so the build stays green
while those six are worked down; it flips to `deny` once they are. This is also
the Rust 2024 default, so it pays off the edition migration early.
* `proc::current_uid()` replaces eight `unsafe { libc::getuid() }` blocks. Each
site had copied out the same SAFETY note verbatim, which is the tell: `getuid()`
is parameterless, always succeeds and touches no memory, so there is no contract
for a caller to uphold and no reason for the unsafe to be visible eight times.
One `unsafe` behind a safe wrapper, none at the call sites.
Verified: `pf-vdisplay` builds clean on Linux (Nobara) at zero E0133; the
macOS-buildable crates build clean locally. No behaviour change.
39 lines
1.6 KiB
TOML
39 lines
1.6 KiB
TOML
[package]
|
|
name = "pf-console-ui"
|
|
description = "The Skia console UI for the Vulkan session binary — stats OSD, capture HUD, and (next) the gamepad library; renders on the presenter's device via the Overlay contract"
|
|
version.workspace = true
|
|
edition.workspace = true
|
|
rust-version.workspace = true
|
|
license.workspace = true
|
|
authors.workspace = true
|
|
repository.workspace = true
|
|
|
|
# Same Linux+Windows gating as the rest of the client stack.
|
|
[target.'cfg(any(target_os = "linux", windows))'.dependencies]
|
|
pf-presenter = { path = "../pf-presenter" }
|
|
# MenuEvent/MenuPulse (the gamepad service's menu mode drives the library).
|
|
pf-client-core = { path = "../pf-client-core" }
|
|
|
|
# Skia on the presenter's VkDevice (`vulkan`); `textlayout` = skparagraph/harfbuzz for
|
|
# the typography the console library needs (~15 MB stripped, prebuilt binaries exist for
|
|
# this feature set on x86_64-unknown-linux-gnu AND x86_64-pc-windows-msvc — a source
|
|
# build is never triggered on either).
|
|
skia-safe = { version = "0.87", features = ["vulkan", "textlayout"] }
|
|
ash = { version = "0.38", features = ["loaded"] }
|
|
|
|
anyhow = "1"
|
|
tracing = "0.1"
|
|
# `config::GamepadPref` keys the button-glyph style (PlayStation shapes vs ABXY).
|
|
punktfunk-core = { path = "../punktfunk-core" }
|
|
|
|
# Linux links the system SDL3; Windows builds it from source (same choice as the rest
|
|
# of the workspace's Windows SDL consumers).
|
|
[target.'cfg(target_os = "linux")'.dependencies]
|
|
sdl3 = { version = "0.18", features = ["hidapi", "ash"] }
|
|
|
|
[target.'cfg(windows)'.dependencies]
|
|
sdl3 = { version = "0.18", features = ["hidapi", "ash", "build-from-source"] }
|
|
|
|
[lints]
|
|
workspace = true
|