Files
punktfunk/sdk/test/runner.test.ts
T
enricobuehler e06ab59652
apple / swift (push) Successful in 1m18s
apple / screenshots (push) Successful in 4m42s
ci / web (push) Successful in 56s
ci / docs-site (push) Successful in 49s
decky / build-publish (push) Successful in 18s
docker / build-push (--build-arg FEDORA_VERSION=44, ci, ci/fedora-rpm.Dockerfile, punktfunk-fedora44-rpm) (push) Successful in 10s
docker / build-push (., web/Dockerfile, punktfunk-web) (push) Successful in 12s
docker / build-push (ci, ci/fedora-rpm.Dockerfile, punktfunk-fedora-rpm) (push) Successful in 8s
ci / bench (push) Successful in 5m14s
docker / build-push (ci, ci/rust-ci.Dockerfile, punktfunk-rust-ci) (push) Successful in 12s
docker / build-push (docs-site, docs-site/Dockerfile, punktfunk-docs) (push) Successful in 56s
arch / build-publish (push) Successful in 15m11s
android / android (push) Successful in 15m50s
deb / build-publish (push) Successful in 16m9s
rpm / build-publish (43, bazzite, punktfunk-fedora-rpm) (push) Successful in 14m12s
rpm / build-publish (44, fedora-44, punktfunk-fedora44-rpm) (push) Successful in 14m8s
ci / rust (push) Successful in 24m55s
docker / deploy-docs (push) Successful in 10s
feat(sdk): punktfunk-scripting — the managed script/plugin runner (M5)
The optional supervision layer (RFC §8): one service runs everything in
<config_dir>/scripts/ plus installed punktfunk-plugin-* packages
(<config_dir>/plugins/node_modules/), as Effect fibers.

- Plugins (a definePlugin default export, either main shape) are
  SUPERVISED: a failure restarts them with capped exponential backoff
  (jittered, 1s→60s); a clean return completes them. The Effect shape
  runs under the PunktfunkHost layer; the async-fn shape gets a facade
  client whose close is scope-guaranteed.
- Bare scripts are one-shot: importing them is the run, no restart
  (export a plugin to be supervised).
- Shutdown is STRUCTURAL: SIGINT/SIGTERM interrupt the whole fiber tree,
  so Effect plugins' scoped finalizers run and clients close before
  exit — the systemctl-stop story, and the reason the Effect plugin
  shape exists at all.
- The sshd rule applies to unit files (world-writable → refused loudly);
  cache-busted imports make restarts real; --list for inventory.

6 new bun tests (17 total green): discovery + refusal, both plugin
shapes against a mock host, crash→restart with backoff, one-shot
semantics, and finalizer-on-interrupt. Live-verified against a real
host: a supervised watcher plugin received library.changed through the
pinned tunnel, and SIGTERM shut the tree down structurally (exit 0).

Deferred to the packaging follow-up (release.yml is in flight in a
parallel session): the vendored-Bun deb/rpm/iss packages and the
host-log-ring tee (needs a host ingest endpoint); console page rides
the other console surfaces.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-17 00:46:16 +02:00

234 lines
7.9 KiB
TypeScript

// The runner's contract: discovery (scripts + plugin packages + the sshd refusal), both plugin
// shapes running against a mock host, crash → supervised restart, one-shot scripts, and the
// M5 heart — structured interruption running scoped finalizers on shutdown.
import { afterAll, describe, expect, test } from "bun:test";
import { Effect, Fiber } from "effect";
import * as fs from "node:fs";
import * as path from "node:path";
import { discoverUnits, runner, superviseUnit } from "../src/runner.js";
const TOKEN = "runner-token";
// Fixtures live under sdk/ so the generated plugin files can resolve "effect" and the SDK.
const ROOT = path.join(import.meta.dir, "..", `.runner-fixtures-${process.pid}`);
fs.mkdirSync(ROOT, { recursive: true });
afterAll(() => fs.rmSync(ROOT, { recursive: true, force: true }));
const mkdirs = (name: string) => {
const dir = path.join(ROOT, name);
fs.mkdirSync(path.join(dir, "scripts"), { recursive: true });
fs.mkdirSync(path.join(dir, "plugins", "node_modules"), { recursive: true });
return {
scriptsDir: path.join(dir, "scripts"),
pluginsDir: path.join(dir, "plugins"),
dir,
};
};
const write = (file: string, content: string) => {
fs.mkdirSync(path.dirname(file), { recursive: true });
fs.writeFileSync(file, content);
fs.chmodSync(file, 0o644);
};
const mockHost = () =>
Bun.serve({
port: 0,
fetch(req) {
if (req.headers.get("authorization") !== `Bearer ${TOKEN}`)
return Response.json({ error: "no" }, { status: 401 });
const p = new URL(req.url).pathname;
if (p === "/api/v1/host") return Response.json({ hostname: "mock" });
if (p === "/api/v1/status") return Response.json({ ok: true });
return Response.json({ error: "nf" }, { status: 404 });
},
});
const waitFor = async (predicate: () => boolean, ms = 5000) => {
const deadline = Date.now() + ms;
while (!predicate()) {
if (Date.now() > deadline) throw new Error("condition never became true");
await new Promise((r) => setTimeout(r, 25));
}
};
describe("discovery", () => {
test("finds scripts + plugin packages, refuses world-writable files", () => {
const d = mkdirs("discover");
write(path.join(d.scriptsDir, "b-script.ts"), "export {};");
write(path.join(d.scriptsDir, "a-script.ts"), "export {};");
write(path.join(d.scriptsDir, "notes.txt"), "not code");
const evil = path.join(d.scriptsDir, "evil.ts");
write(evil, "export {};");
fs.chmodSync(evil, 0o777);
write(
path.join(d.pluginsDir, "node_modules", "punktfunk-plugin-x", "package.json"),
JSON.stringify({ name: "punktfunk-plugin-x", main: "index.js" }),
);
write(
path.join(d.pluginsDir, "node_modules", "punktfunk-plugin-x", "index.js"),
"export default { name: 'x', main: async () => {} };",
);
write(
path.join(d.pluginsDir, "node_modules", "unrelated-pkg", "package.json"),
JSON.stringify({ name: "unrelated-pkg" }),
);
const logs: string[] = [];
const units = discoverUnits(d, (l) => logs.push(l));
expect(units.map((u) => u.name)).toEqual([
"a-script",
"b-script",
"punktfunk-plugin-x",
]);
expect(logs.join("\n")).toContain("REFUSING");
expect(logs.join("\n")).toContain("evil.ts");
});
});
describe("supervision", () => {
test("async-fn plugin runs with a facade client; clean return completes", async () => {
const server = mockHost();
const d = mkdirs("fn-plugin");
const out = path.join(d.dir, "out.txt");
write(
path.join(d.scriptsDir, "fn.ts"),
`export default { name: "fn", main: async (pf) => {
const host = await pf.request("GET", "/host");
require("node:fs").writeFileSync(${JSON.stringify(out)}, host.hostname);
}};`,
);
const logs: string[] = [];
try {
const fiber = Effect.runFork(
runner({
...d,
connect: { url: `http://127.0.0.1:${server.port}`, token: TOKEN },
log: (l) => logs.push(l),
}),
);
await waitFor(() => fs.existsSync(out));
expect(fs.readFileSync(out, "utf8")).toBe("mock");
await waitFor(() => logs.some((l) => l.includes("[fn] plugin completed")));
await Effect.runPromise(Fiber.interrupt(fiber));
} finally {
server.stop(true);
}
});
test("a crashing plugin is restarted with backoff", async () => {
const server = mockHost();
const d = mkdirs("crashy");
const counter = path.join(d.dir, "count.txt");
write(
path.join(d.scriptsDir, "crashy.ts"),
`import * as fs from "node:fs";
export default { name: "crashy", main: async () => {
const n = fs.existsSync(${JSON.stringify(counter)}) ? Number(fs.readFileSync(${JSON.stringify(counter)}, "utf8")) : 0;
fs.writeFileSync(${JSON.stringify(counter)}, String(n + 1));
throw new Error("boom " + n);
}};`,
);
const logs: string[] = [];
try {
const fiber = Effect.runFork(
runner({
...d,
connect: { url: `http://127.0.0.1:${server.port}`, token: TOKEN },
restartBase: "20 millis",
log: (l) => logs.push(l),
}),
);
await waitFor(() => {
try {
return Number(fs.readFileSync(counter, "utf8")) >= 3;
} catch {
return false;
}
});
expect(logs.some((l) => l.includes("[crashy] failed: "))).toBe(true);
expect(logs.some((l) => l.includes("restarting (attempt 2)"))).toBe(true);
await Effect.runPromise(Fiber.interrupt(fiber));
} finally {
server.stop(true);
}
});
test("a bare script is one-shot: runs on import, never restarts", async () => {
const d = mkdirs("bare");
const counter = path.join(d.dir, "ran.txt");
write(
path.join(d.scriptsDir, "once.ts"),
`import * as fs from "node:fs";
const n = fs.existsSync(${JSON.stringify(counter)}) ? Number(fs.readFileSync(${JSON.stringify(counter)}, "utf8")) : 0;
fs.writeFileSync(${JSON.stringify(counter)}, String(n + 1));`,
);
const logs: string[] = [];
const fiber = Effect.runFork(
runner({ ...d, restartBase: "20 millis", log: (l) => logs.push(l) }),
);
await waitFor(() => logs.some((l) => l.includes("[once] script completed")));
await new Promise((r) => setTimeout(r, 200)); // would have restarted by now
expect(fs.readFileSync(counter, "utf8")).toBe("1");
await Effect.runPromise(Fiber.interrupt(fiber));
});
test("shutdown interrupts an Effect plugin STRUCTURALLY — its finalizer runs", async () => {
const server = mockHost();
const d = mkdirs("finalizer");
const acquired = path.join(d.dir, "acquired.txt");
const released = path.join(d.dir, "released.txt");
write(
path.join(d.scriptsDir, "holder.ts"),
`import { Effect } from "effect";
import * as fs from "node:fs";
export default { name: "holder", main: Effect.scoped(Effect.gen(function* () {
yield* Effect.acquireRelease(
Effect.sync(() => fs.writeFileSync(${JSON.stringify(acquired)}, "1")),
() => Effect.sync(() => fs.writeFileSync(${JSON.stringify(released)}, "1")),
);
yield* Effect.never; // hold the resource for the plugin's lifetime
})) };`,
);
try {
const fiber = Effect.runFork(
runner({
...d,
connect: { url: `http://127.0.0.1:${server.port}`, token: TOKEN },
log: () => {},
}),
);
await waitFor(() => fs.existsSync(acquired));
expect(fs.existsSync(released)).toBe(false);
await Effect.runPromise(Fiber.interrupt(fiber)); // the SIGTERM path
await waitFor(() => fs.existsSync(released));
} finally {
server.stop(true);
}
});
test("supervised unit ends cleanly when its plugin completes (no spin)", async () => {
const server = mockHost();
const d = mkdirs("done");
write(
path.join(d.scriptsDir, "done.ts"),
`export default { name: "done", main: async () => {} };`,
);
const logs: string[] = [];
try {
await Effect.runPromise(
superviseUnit(
{ name: "done", file: path.join(d.scriptsDir, "done.ts") },
{
connect: { url: `http://127.0.0.1:${server.port}`, token: TOKEN },
log: (l) => logs.push(l),
restartBase: "10 millis",
},
),
);
expect(logs.filter((l) => l.includes("restarting")).length).toBe(0);
} finally {
server.stop(true);
}
});
});