enricobuehler
10a0ef3283
The kit had NO biome config and no lint script, while every plugin repo that
consumes it has both. So its source quietly drifted — unused imports, unsorted
imports, formatting — with nothing to catch any of it. Running biome here for
the first time reported 20 findings across 8 files.
Adds `plugin-kit/biome.json` mirroring the plugin repos' (tab indent, double
quotes, recommended lint preset, organizeImports), a `check` script, and
`@biomejs/biome` pinned to the same `^2.5.2` the plugins pin — without that pin
`bunx biome` resolved 2.4.6, which rejects the 2.5 `rules.preset` key.
Two deliberate differences from the plugin repos' copy:
* no `vcs.useIgnoreFile` — those are standalone repos with a .gitignore beside
the config; plugin-kit is a directory inside this one, and biome errors with
"couldn't find an ignore file". The `files.includes` exclusions cover it.
* `!examples/**/dist` instead of `!ui/dist` — the kit has examples, not a UI.
`css.parser.tailwindDirectives` is carried over and is load-bearing: without it
biome cannot parse `@theme` in src/theme.css and reports three parse errors on
CSS that is perfectly valid Tailwind v4.
Everything here is formatter/import churn except two real findings, both fixed:
* `Layer` (library/define.ts) and `Cause` (sync-engine.ts) were imported and
never used;
* test/spike-httpapi.test.ts read `(reg?.body as …).ui.secret` one line after
`expect(reg).toBeDefined()`. The optional chain undoes the assertion: had
`reg` been undefined the `.ui` access would throw a TypeError instead of
failing the test readably. Now asserted to the type system too.
Wired into plugin-kit-publish.yml as a `Lint & format` step ahead of Typecheck,
so this cannot rot again.
Gates after: biome clean (42 files), tsc clean, 67/67 tests, build clean.
27 lines
1.1 KiB
TypeScript
27 lines
1.1 KiB
TypeScript
// Runner-journal logging: one stamped line per log call, `<ISO> [<plugin>] <message>`,
|
|
// matching the format the scripting runner journals (and what the previous hand-rolled
|
|
// plugin loggers emitted), so kit-based plugins read consistently in
|
|
// `journalctl --user -u punktfunk-scripting`.
|
|
import { Cause, type Layer, Logger } from "effect";
|
|
|
|
const render = (message: unknown): string => {
|
|
if (typeof message === "string") return message;
|
|
if (Array.isArray(message)) return message.map(render).join(" ");
|
|
return typeof message === "object"
|
|
? JSON.stringify(message)
|
|
: String(message);
|
|
};
|
|
|
|
/** Replace the default logger with the runner-journal format. */
|
|
export const loggingLayer = (plugin: string): Layer.Layer<never> =>
|
|
Logger.layer([
|
|
Logger.make(({ message, logLevel, cause, date }) => {
|
|
const level = logLevel === "Info" ? "" : ` ${logLevel.toUpperCase()}:`;
|
|
const causeSuffix =
|
|
cause.reasons.length > 0 ? ` ${Cause.pretty(cause)}` : "";
|
|
console.log(
|
|
`${date.toISOString()} [${plugin}]${level} ${render(message)}${causeSuffix}`,
|
|
);
|
|
}),
|
|
]);
|