Files
punktfunk/plugin-kit/src/library/parsers/fs.ts
T
enricobuehler 10a0ef3283 style(plugin-kit): adopt the biome config its own plugins already use
The kit had NO biome config and no lint script, while every plugin repo that
consumes it has both. So its source quietly drifted — unused imports, unsorted
imports, formatting — with nothing to catch any of it. Running biome here for
the first time reported 20 findings across 8 files.

Adds `plugin-kit/biome.json` mirroring the plugin repos' (tab indent, double
quotes, recommended lint preset, organizeImports), a `check` script, and
`@biomejs/biome` pinned to the same `^2.5.2` the plugins pin — without that pin
`bunx biome` resolved 2.4.6, which rejects the 2.5 `rules.preset` key.

Two deliberate differences from the plugin repos' copy:

  * no `vcs.useIgnoreFile` — those are standalone repos with a .gitignore beside
    the config; plugin-kit is a directory inside this one, and biome errors with
    "couldn't find an ignore file". The `files.includes` exclusions cover it.
  * `!examples/**/dist` instead of `!ui/dist` — the kit has examples, not a UI.

`css.parser.tailwindDirectives` is carried over and is load-bearing: without it
biome cannot parse `@theme` in src/theme.css and reports three parse errors on
CSS that is perfectly valid Tailwind v4.

Everything here is formatter/import churn except two real findings, both fixed:

  * `Layer` (library/define.ts) and `Cause` (sync-engine.ts) were imported and
    never used;
  * test/spike-httpapi.test.ts read `(reg?.body as …).ui.secret` one line after
    `expect(reg).toBeDefined()`. The optional chain undoes the assertion: had
    `reg` been undefined the `.ui` access would throw a TypeError instead of
    failing the test readably. Now asserted to the type system too.

Wired into plugin-kit-publish.yml as a `Lint & format` step ahead of Typecheck,
so this cannot rot again.

Gates after: biome clean (42 files), tsc clean, 67/67 tests, build clean.
2026-08-08 02:19:06 +02:00

113 lines
4.1 KiB
TypeScript

// Bounded filesystem reads and path confinement — the posture the in-host scanners established,
// ported so a library plugin inherits it instead of re-deriving it.
//
// The rules here exist because a plugin reads files it does not own: a launcher's manifests, a
// catalog cache, a `goggame-*.info` a user could have edited. None of that is hostile in the normal
// case, and all of it is untrusted in the case that matters.
import * as fs from "node:fs";
import * as path from "node:path";
/** A launcher manifest / `.acf` / `.info`: text, small. Matches `epic.rs`'s posture. */
export const MAX_MANIFEST_BYTES = 1024 * 1024;
/** A binary catalog cache (Epic's `catcache.bin`, a `shortcuts.vdf`): larger, still bounded. */
export const MAX_CACHE_BYTES = 32 * 1024 * 1024;
/**
* Read a file as UTF-8, refusing anything over `max`. `undefined` on any error, a non-regular file,
* or an over-cap file — a plugin scanning a directory must never die on one odd entry.
*
* The size is checked by `stat` BEFORE the read, so an enormous file costs a stat, not the memory.
*/
export const readTextCapped = (
file: string,
max = MAX_MANIFEST_BYTES,
): string | undefined => {
try {
const st = fs.statSync(file);
if (!st.isFile() || st.size === 0 || st.size > max) return undefined;
return fs.readFileSync(file, "utf8");
} catch {
return undefined;
}
};
/** Read a file as bytes, refusing anything over `max`. Same posture as {@link readTextCapped}. */
export const readBytesCapped = (
file: string,
max = MAX_CACHE_BYTES,
): Uint8Array | undefined => {
try {
const st = fs.statSync(file);
if (!st.isFile() || st.size === 0 || st.size > max) return undefined;
return new Uint8Array(fs.readFileSync(file));
} catch {
return undefined;
}
};
/** Read + `JSON.parse` a capped text file. `undefined` on any read or parse failure. */
export const readJsonCapped = <T = unknown>(
file: string,
max = MAX_MANIFEST_BYTES,
): T | undefined => {
const text = readTextCapped(file, max);
if (text === undefined) return undefined;
try {
return JSON.parse(text) as T;
} catch {
return undefined;
}
};
/** List a directory's entry names, or `[]` if it isn't readable. */
export const listDir = (dir: string): string[] => {
try {
return fs.readdirSync(dir);
} catch {
return [];
}
};
/** Does this path exist as a directory? */
export const isDir = (p: string): boolean => {
try {
return fs.statSync(p).isDirectory();
} catch {
return false;
}
};
/** Does this path exist as a regular, non-empty file? */
export const isFile = (p: string): boolean => {
try {
const st = fs.statSync(p);
return st.isFile() && st.size > 0;
} catch {
return false;
}
};
/**
* Join `rel` onto `base` **only if it cannot escape** — the port of the host's `confined_join`
* (gog.rs), which exists because a crafted `goggame-<id>.info` could otherwise point a play task's
* exe at an arbitrary program (security-review 2026-07-17).
*
* Refuses any relative path carrying a drive prefix (`C:`), a root (`/` or `\`), or a `..`
* component — each of which `path.join` would let REPLACE or climb out of `base`. `undefined` ⇒
* out of bounds, and the caller must refuse the launch rather than fall back to something plausible.
*/
export const confinedJoin = (base: string, rel: string): string | undefined => {
if (rel === "") return undefined;
// Normalize separators so a Windows-shaped relative path is checked on any platform (a plugin
// may parse a Windows manifest while its tests run on Linux).
const parts = rel.split(/[\\/]/);
if (parts[0] === "") return undefined; // rooted
if (/^[A-Za-z]:$/.test(parts[0])) return undefined; // drive prefix
if (parts.some((p) => p === "..")) return undefined; // traversal
const joined = path.join(base, ...parts.filter((p) => p !== "" && p !== "."));
// Belt and braces: the component check above is the real guard, but a symlink-free string check
// costs nothing and catches anything the split missed.
const rootWithSep = base.endsWith(path.sep) ? base : base + path.sep;
return joined === base || joined.startsWith(rootWithSep) ? joined : undefined;
};