7b99b41ede
Much of design/ described work that has since shipped. Trim each doc to
its durable rationale + still-open items (the code is the source of truth
for shipped detail; git history holds the full originals).
- Shipped plans -> status stubs: stats-capture, gamestream-host-plan,
apple-stage2-presenter, windows-service.
- Trimmed completed-out / open-kept: implementation-plan, hdr-pipeline,
host-latency, gpu-contention (fixed stale status table), game-library,
linux-setup (fixed m0->spike + stale zero-copy claim),
session-aware-host-followups, windows-client-bootstrap,
windows-dualsense-{scoping,game-detection}, windows-virtual-display,
security-review (per-finding status table; #12 still open),
apollo-comparison (shipped backlog collapsed to one-liners).
- Windows-host cluster consolidated: windows-host.md -> redirect into
windows-host-rewrite.md (whose stale scorecard is corrected -- goal1 is
merged, M4 done); windows-secure-desktop.md archived (now a fallback
behind IDD-push primary).
- Kept evergreen: ci.md, gamescope-multiuser.md, windows-build-and-packaging.md.
- New design/README.md: per-doc status table + consolidated open-items
roll-up so nothing is tracked in only one buried doc.
- Repoint 5 code comments to the archived secure-desktop doc path.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
145 lines
6.2 KiB
Rust
145 lines
6.2 KiB
Rust
//! Input-desktop watcher (Windows) — the authoritative "normal vs secure desktop" signal for the
|
|
//! two-process secure-desktop design (design/archive/windows-secure-desktop.md).
|
|
//!
|
|
//! Windows switches the *input desktop* to "Winlogon" (the secure desktop) for UAC elevation, the
|
|
//! lock screen and the login screen, and back to "Default" for the normal session. WGC captures only
|
|
//! the normal desktop; DDA-as-SYSTEM captures the secure one. A dedicated thread polls the input
|
|
//! desktop's NAME (WTS session notifications miss UAC entirely, so the name is the reliable signal)
|
|
//! and publishes it as an atomic the capture mux + input path read.
|
|
|
|
// Every `unsafe` block in this file carries a `// SAFETY:` proof; enforce it (unsafe-proof program).
|
|
#![deny(clippy::undocumented_unsafe_blocks)]
|
|
|
|
use std::sync::atomic::{AtomicBool, AtomicU8, Ordering};
|
|
use std::sync::Arc;
|
|
use std::time::Duration;
|
|
use windows::Win32::Foundation::HANDLE;
|
|
use windows::Win32::System::StationsAndDesktops::{
|
|
CloseDesktop, GetUserObjectInformationW, OpenInputDesktop, DESKTOP_ACCESS_FLAGS,
|
|
DESKTOP_CONTROL_FLAGS, UOI_NAME,
|
|
};
|
|
|
|
/// The normal interactive desktop ("Default") — WGC capture applies.
|
|
pub const DESKTOP_NORMAL: u8 = 0;
|
|
/// The secure desktop ("Winlogon": UAC / lock / login) — DDA-as-SYSTEM capture applies.
|
|
pub const DESKTOP_SECURE: u8 = 1;
|
|
|
|
/// Polls the input-desktop name on its own thread and publishes [`DESKTOP_NORMAL`]/[`DESKTOP_SECURE`].
|
|
pub struct DesktopWatcher {
|
|
state: Arc<AtomicU8>,
|
|
stop: Arc<AtomicBool>,
|
|
}
|
|
|
|
impl DesktopWatcher {
|
|
pub fn start() -> Self {
|
|
// Compute the CURRENT desktop synchronously before returning, so the first reader (the capture
|
|
// mux) sees the real state immediately. Otherwise a session that begins already on the secure
|
|
// desktop (e.g. a reconnect to a locked box) would read DESKTOP_NORMAL for the first poll
|
|
// interval and relay one stale normal-desktop frame — the "flash of the login screen" bug.
|
|
// SAFETY: `is_secure_desktop` is this module's `unsafe fn` — unsafe only because it calls Win32
|
|
// desktop FFI (`OpenInputDesktop`/`GetUserObjectInformationW`/`CloseDesktop`), with no caller
|
|
// precondition; it opens, names, and closes the input-desktop handle internally and is safe to
|
|
// call from any thread (here, on the thread running `DesktopWatcher::start`).
|
|
let initial = if unsafe { is_secure_desktop() } {
|
|
DESKTOP_SECURE
|
|
} else {
|
|
DESKTOP_NORMAL
|
|
};
|
|
let state = Arc::new(AtomicU8::new(initial));
|
|
let stop = Arc::new(AtomicBool::new(false));
|
|
let s = state.clone();
|
|
let st = stop.clone();
|
|
let _ = std::thread::Builder::new()
|
|
.name("desktop-watch".into())
|
|
.spawn(move || {
|
|
// Debounce: only publish a change after the raw reading has been stable for several
|
|
// polls. The input desktop flaps Default↔Winlogon transiently during a lock/UAC
|
|
// transition; publishing every flap makes the capture mux thrash (rebuild storms).
|
|
const STABLE_POLLS: u32 = 4; // ~80ms
|
|
let mut published = initial;
|
|
let mut candidate = initial;
|
|
let mut stable = 0u32;
|
|
while !st.load(Ordering::Relaxed) {
|
|
// SAFETY: same as in `start` — `is_secure_desktop` is self-contained Win32 desktop
|
|
// FFI with no caller precondition, called here on the dedicated `desktop-watch`
|
|
// polling thread.
|
|
let v = if unsafe { is_secure_desktop() } {
|
|
DESKTOP_SECURE
|
|
} else {
|
|
DESKTOP_NORMAL
|
|
};
|
|
if v == candidate {
|
|
stable = stable.saturating_add(1);
|
|
} else {
|
|
candidate = v;
|
|
stable = 1;
|
|
}
|
|
if stable >= STABLE_POLLS && candidate != published {
|
|
s.store(candidate, Ordering::Release);
|
|
published = candidate;
|
|
tracing::info!(
|
|
desktop = if candidate == DESKTOP_SECURE {
|
|
"Winlogon(secure)"
|
|
} else {
|
|
"Default"
|
|
},
|
|
"input desktop changed (debounced)"
|
|
);
|
|
}
|
|
std::thread::sleep(Duration::from_millis(20));
|
|
}
|
|
});
|
|
DesktopWatcher { state, stop }
|
|
}
|
|
|
|
/// The shared atomic ([`DESKTOP_NORMAL`]/[`DESKTOP_SECURE`]) for the capture mux to read.
|
|
pub fn state(&self) -> Arc<AtomicU8> {
|
|
self.state.clone()
|
|
}
|
|
|
|
/// True when the secure (Winlogon) desktop is the input desktop right now.
|
|
pub fn is_secure(&self) -> bool {
|
|
self.state.load(Ordering::Acquire) == DESKTOP_SECURE
|
|
}
|
|
}
|
|
|
|
impl Drop for DesktopWatcher {
|
|
fn drop(&mut self) {
|
|
self.stop.store(true, Ordering::Relaxed);
|
|
}
|
|
}
|
|
|
|
/// True if the current input desktop is "Winlogon" (the secure desktop). Best-effort: if the desktop
|
|
/// can't be opened or named, report not-secure (the safe default — keep WGC/normal capture).
|
|
pub(crate) unsafe fn is_secure_desktop() -> bool {
|
|
let desk = match OpenInputDesktop(
|
|
DESKTOP_CONTROL_FLAGS(0),
|
|
false,
|
|
DESKTOP_ACCESS_FLAGS(DESKTOP_READOBJECTS),
|
|
) {
|
|
Ok(d) => d,
|
|
Err(_) => return false,
|
|
};
|
|
let mut buf = [0u16; 64];
|
|
let mut needed = 0u32;
|
|
let ok = GetUserObjectInformationW(
|
|
HANDLE(desk.0),
|
|
UOI_NAME,
|
|
Some(buf.as_mut_ptr() as *mut _),
|
|
(buf.len() * 2) as u32,
|
|
Some(&mut needed),
|
|
)
|
|
.is_ok();
|
|
let _ = CloseDesktop(desk);
|
|
if !ok {
|
|
return false;
|
|
}
|
|
let name = String::from_utf16_lossy(&buf);
|
|
name.trim_end_matches('\u{0}')
|
|
.eq_ignore_ascii_case("Winlogon")
|
|
}
|
|
|
|
/// `DESKTOP_READOBJECTS` access right (the windows crate exposes it as a typed flag; we need the raw
|
|
/// bit for `OpenInputDesktop`'s access mask).
|
|
const DESKTOP_READOBJECTS: u32 = 0x0001;
|