M2 of design/library-scanner-plugins-implementation-plan.md. Everything a
library scanner plugin needs is now expressible over the API; all additive.
WP2.1/2.2 — store claims (D2). library.json gains a v2 shape ({entries, claims})
that loads the v1 bare array unchanged and is written on the first mutation.
PUT /library/provider/{p}?store=<s> claims a store for a provider: its entries
then surface with deterministic <store>:<external_id> ids and the store's own
badge instead of opaque custom:<id> ones. That identity is the whole point —
entry ids, GameStream FNV app ids, client art caches and Moonlight pins all
survive a title moving from an in-host scanner to a plugin. One provider per
store (409 otherwise); DELETE releases; an empty reconcile does NOT (a store can
legitimately have zero titles). While a claim is held, all_games() skips the
matching built-in scanner, so the two never double-list during the bridge.
WP2.3 — DetectHint gains steam_appid and env_marker, the two store-derived
signals the host used to read for itself. Without them a steam plugin's lease
tracking would drop from reaper-exact to dir-prefix, and Heroic-under-Proton
would lose the only signal that works. Malformed markers are dropped, not
honoured — this feeds a path that can end processes.
WP2.4/2.5 — role: game|launcher on the entry shapes (serde-default, skipped when
default), and a steam_ui launch kind valued bigpicture|desktop that opens the
Steam client itself. Validated inbound as well as at launch.
WP2.6 — GET/PUT /library/scanners generalizes to SOURCES: built-in scanners
minus claimed ones, plus claimed stores, plus any provider with entries. The
same library-scanners.json disabled-set backs all of them and the ids match by
construction, so a user's disabled state carries over verbatim through the whole
migration. A disabled plugin source has its entries filtered at read time,
exactly like a disabled scanner.
WP2.7/2.8 — plugin registration gains a category field (the console keeps
library plugins out of the nav); index entries gain categories and per-platform
detect probes, evaluated existence-only into CatalogEntry.detected so the host
never re-grows per-store knowledge. Index SCHEMA stays 1 — additive.
WP2.9 — OpenAPI + SDK regenerated on Linux; kit wire widened (LaunchSpec.kind is
now a plain string documented against the host's vocabulary — closes G3), and
ProviderClient.reconcile takes an optional store and returns the host's echoed
entries so a caller can detect a pre-M2 host silently ignoring the claim.
Also fixes a bug the S3 spike turned up: is_steam_launch gated on a steam:// URI,
so a steam_ui launcher entry would have skipped BOTH gamescope's --steam mode and
the B1 single-instance free — on a box autologged into game mode, the nested
second Steam would see the first and exit, crashing the spawn. It now tests the
first token.
Gates on .21: workspace tests green (punktfunk-host 425 passed), workspace
clippy -D warnings clean, cargo fmt --all --check clean, OpenAPI drift test
green. plugin-kit: tsc clean, 20 tests pass.
81 lines
3.0 KiB
TypeScript
81 lines
3.0 KiB
TypeScript
// The library-provider client, owned by the kit so plugins stop hand-copying host calls.
|
|
// The wire SCHEMAS live in ./wire.ts (browser-safe — plugin contracts re-use them); the
|
|
// transport here stays the SDK's untyped `pf.request` seam (version-skew-safe under the
|
|
// runner-bundled SDK — design D7).
|
|
import { Context, Effect, Layer } from "effect";
|
|
import type { HostRequestError } from "./errors.js";
|
|
import { HostClient } from "./host-client.js";
|
|
import type { ProviderEntry } from "./wire.js";
|
|
|
|
export * from "./wire.js";
|
|
|
|
/** What the host echoed back for one reconciled entry — enough to tell whether a claim took. */
|
|
export interface ReconciledEntry {
|
|
readonly id: string;
|
|
readonly external_id?: string;
|
|
/** The store badge the host assigned: the claim when it honoured one, else `"custom"`. */
|
|
readonly store?: string;
|
|
}
|
|
|
|
export interface ProviderClientService {
|
|
/**
|
|
* Full-replace reconcile: PUT the desired set; the host diffs by `external_id`.
|
|
*
|
|
* `store` claims that store for this provider (design D2), which is what makes the entries carry
|
|
* the store's own identity — deterministic `<store>:<external_id>` ids instead of opaque
|
|
* `custom:<id>` ones, the store's badge, and suppression of the host's matching built-in scanner
|
|
* so the two never double-list. One provider per store: a second claimant gets a 409.
|
|
*
|
|
* Returns the host's echoed entries so a caller can verify the claim actually took — a host
|
|
* predating claims ignores the query parameter silently, and the only way to notice is that the
|
|
* entries come back as `custom`.
|
|
*/
|
|
readonly reconcile: (
|
|
providerId: string,
|
|
entries: ReadonlyArray<ProviderEntry>,
|
|
store?: string,
|
|
) => Effect.Effect<ReadonlyArray<ReconciledEntry>, HostRequestError>;
|
|
/**
|
|
* Remove every entry this provider owns **and release its store claim** (the explicit-uninstall
|
|
* path). Releasing is what brings the host's built-in scanner back.
|
|
*/
|
|
readonly remove: (providerId: string) => Effect.Effect<void, HostRequestError>;
|
|
}
|
|
|
|
export class ProviderClient extends Context.Service<
|
|
ProviderClient,
|
|
ProviderClientService
|
|
>()("@punktfunk/plugin-kit/ProviderClient") {
|
|
static readonly layer: Layer.Layer<ProviderClient, never, HostClient> =
|
|
Layer.effect(ProviderClient)(
|
|
Effect.gen(function* () {
|
|
const host = yield* HostClient;
|
|
return {
|
|
reconcile: (providerId, entries, store) =>
|
|
host
|
|
.request(
|
|
"PUT",
|
|
`/library/provider/${providerId}${
|
|
store ? `?store=${encodeURIComponent(store)}` : ""
|
|
}`,
|
|
entries,
|
|
)
|
|
.pipe(
|
|
// The host answers with its resulting entries. An older host may answer
|
|
// with something else, so treat a non-array as "no echo" rather than
|
|
// failing the sync.
|
|
Effect.map((body) =>
|
|
Array.isArray(body)
|
|
? (body as ReadonlyArray<ReconciledEntry>)
|
|
: [],
|
|
),
|
|
),
|
|
remove: (providerId) =>
|
|
host
|
|
.request("DELETE", `/library/provider/${providerId}`)
|
|
.pipe(Effect.asVoid),
|
|
} satisfies ProviderClientService;
|
|
}),
|
|
);
|
|
}
|