enricobuehler
10a0ef3283
The kit had NO biome config and no lint script, while every plugin repo that
consumes it has both. So its source quietly drifted — unused imports, unsorted
imports, formatting — with nothing to catch any of it. Running biome here for
the first time reported 20 findings across 8 files.
Adds `plugin-kit/biome.json` mirroring the plugin repos' (tab indent, double
quotes, recommended lint preset, organizeImports), a `check` script, and
`@biomejs/biome` pinned to the same `^2.5.2` the plugins pin — without that pin
`bunx biome` resolved 2.4.6, which rejects the 2.5 `rules.preset` key.
Two deliberate differences from the plugin repos' copy:
* no `vcs.useIgnoreFile` — those are standalone repos with a .gitignore beside
the config; plugin-kit is a directory inside this one, and biome errors with
"couldn't find an ignore file". The `files.includes` exclusions cover it.
* `!examples/**/dist` instead of `!ui/dist` — the kit has examples, not a UI.
`css.parser.tailwindDirectives` is carried over and is load-bearing: without it
biome cannot parse `@theme` in src/theme.css and reports three parse errors on
CSS that is perfectly valid Tailwind v4.
Everything here is formatter/import churn except two real findings, both fixed:
* `Layer` (library/define.ts) and `Cause` (sync-engine.ts) were imported and
never used;
* test/spike-httpapi.test.ts read `(reg?.body as …).ui.secret` one line after
`expect(reg).toBeDefined()`. The optional chain undoes the assertion: had
`reg` been undefined the `.ui` access would throw a TypeError instead of
failing the test readably. Now asserted to the type system too.
Wired into plugin-kit-publish.yml as a `Lint & format` step ahead of Typecheck,
so this cannot rot again.
Gates after: biome clean (42 files), tsc clean, 67/67 tests, build clean.
32 lines
1.1 KiB
TypeScript
32 lines
1.1 KiB
TypeScript
// sseRoute: frame format + integration with the toWebHandler pipeline.
|
|
import { describe, expect, test } from "bun:test";
|
|
import { Layer, Schedule, Stream } from "effect";
|
|
import { HttpRouter } from "effect/unstable/http";
|
|
import { httpApiEnv, sseRoute } from "../src/index.js";
|
|
|
|
describe("sseRoute", () => {
|
|
test("streams event frames in SSE wire format", async () => {
|
|
const stream = Stream.fromSchedule(Schedule.spaced("5 millis")).pipe(
|
|
Stream.map((n) => ({ tick: Number(n) })),
|
|
Stream.take(3),
|
|
);
|
|
const routes = sseRoute("/api/events", stream, {
|
|
event: "status",
|
|
pingSeconds: 0,
|
|
});
|
|
const { handler, dispose } = HttpRouter.toWebHandler(
|
|
Layer.provide(routes, httpApiEnv),
|
|
);
|
|
try {
|
|
const res = await handler(new Request("http://127.0.0.1/api/events"));
|
|
expect(res.status).toBe(200);
|
|
expect(res.headers.get("content-type")).toContain("text/event-stream");
|
|
const text = await res.text();
|
|
expect(text).toContain('event: status\ndata: {"tick":0}\n\n');
|
|
expect(text).toContain('event: status\ndata: {"tick":2}\n\n');
|
|
} finally {
|
|
await dispose();
|
|
}
|
|
});
|
|
});
|