Seven medium findings from the round-1 sweep, all in pf-zerocopy. Adjudicated
against source; all zero-copy-preserving (no GPU→CPU→GPU roundtrip introduced).
- import_src (vulkan.rs) leaked a VkBuffer + VkDeviceMemory + dup'd fd on every
fallible step before the success-only src_cache.insert. A failed import is
survived by the worker and RETRIED by the caller every frame, so this leaked
per frame for the worker's whole lifetime. Now owns the dup fd via OwnedFd
(closes on early return until Vulkan consumes it at allocate_memory) and
destroys the buffer + frees memory on each error path.
- ensure_dst destroyed the old exportable buffer and nulled self.dst BEFORE
building the replacement, so a failed rebuild both dropped the working buffer
and leaked every object the partial rebuild created (raw ash handles, no Drop;
VkBridge::drop only frees the live self.dst). Now builds fully, unwinds each
error locally, and swaps only on success.
- The submit→wait→reset sequence in import_linear_nv12 / import_linear `?`-ed out
of wait_for_fences BEFORE reset_fences on a TIMEOUT/DEVICE_LOST, leaving the
shared self.cmd PENDING and self.fence IN-USE while the caller retries on the
same bridge (and ensure_dst later destroys dst.buffer assuming nothing is in
flight). Now drains the GPU (device_wait_idle) and resets the fence before
propagating — fixing the reported ensure_dst UAF at its source.
- copy_pitched_nv12_to_buffer writes height.div_ceil(2) chroma rows into a UV
plane sized at height/2, so an odd height overruns by one uv_pitch row (OOB
device write / CUDA_ERROR_ILLEGAL_ADDRESS). Added the even-dimension guard to
import_linear_nv12, matching Nv12Blit/Yuv444Blit.
- sweep_reaper only reaped already-exited workers, so a worker wedged inside a
driver call lingered forever holding its CUcontext + BufferPool (hundreds of MB
VRAM). Now force-kills a child parked past REAPER_KILL_DEADLINE (20s).
Compile + tests green on Linux .21 (RTX 5070 Ti): pf-zerocopy 17/0. The error
paths themselves are not fault-injected; the fixes are structural.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
enricobuehlerandClaude Opus 4.8
26ff005e70