enricobuehler
5219107177
`packaging/windows/drivers/*` has run `deny(unsafe_op_in_unsafe_fn)` +
`deny(clippy::undocumented_unsafe_blocks)` for a while, with `forbid(unsafe_code)`
on the modules that need no unsafe at all. The main workspace had no lint config
whatsoever, so nothing stopped a clean crate from quietly growing an `unsafe`, and
nothing distinguished the handful of genuinely-unsafe lines inside a 600-line
`unsafe fn` from the safe ones surrounding them.
Three things, all mechanical:
* `#![forbid(unsafe_code)]` on the eight crates that already contain zero unsafe
(`pf-driver-proto`, `pf-host-config`, `pf-paths`, the three clean clients, both
tools). These were clean by accident, not by contract; now they are clean by
contract.
* `unsafe_op_in_unsafe_fn = "warn"` workspace-wide. `unsafe fn` states a contract
the CALLER must uphold — it was never meant to switch off checking for the whole
body. Measured fallout is 300 sites on Linux, and they are concentrated: six
files carry all of them, while `punktfunk-core`, `pf-frame`, `pf-clipboard` and
`pf-vdisplay` are already at zero. `warn` (not `deny`) so the build stays green
while those six are worked down; it flips to `deny` once they are. This is also
the Rust 2024 default, so it pays off the edition migration early.
* `proc::current_uid()` replaces eight `unsafe { libc::getuid() }` blocks. Each
site had copied out the same SAFETY note verbatim, which is the tell: `getuid()`
is parameterless, always succeeds and touches no memory, so there is no contract
for a caller to uphold and no reason for the unsafe to be visible eight times.
One `unsafe` behind a safe wrapper, none at the call sites.
Verified: `pf-vdisplay` builds clean on Linux (Nobara) at zero E0133; the
macOS-buildable crates build clean locally. No behaviour change.
59 lines
2.6 KiB
TOML
59 lines
2.6 KiB
TOML
[package]
|
|
name = "pf-presenter"
|
|
description = "The Vulkan session presenter — SDL3 window, ash swapchain, frame present, input capture; the stage-2 presenter of punktfunk-planning linux-client-rearchitecture.md"
|
|
version.workspace = true
|
|
edition.workspace = true
|
|
rust-version.workspace = true
|
|
license.workspace = true
|
|
authors.workspace = true
|
|
repository.workspace = true
|
|
|
|
# Same Linux+Windows gating as the rest of the client stack (dmabuf import is the one
|
|
# Linux-only module — see lib.rs).
|
|
[target.'cfg(any(target_os = "linux", windows))'.dependencies]
|
|
# `default-features = false`: the PyroWave decode backend is turned on through THIS crate's own
|
|
# `pyrowave` feature (which re-exports it below), never by inheriting the dependency's default.
|
|
# Otherwise a consumer that deliberately builds us without `pyrowave` still drags the vendored
|
|
# C++ in — fatal on Windows ARM64, where Granite has no SIMD path.
|
|
pf-client-core = { path = "../pf-client-core", default-features = false }
|
|
# AVVkFrame access (Vulkan Video frames: live sync state under the frames lock).
|
|
pf-ffvk = { path = "../pf-ffvk" }
|
|
punktfunk-core = { path = "../punktfunk-core", features = ["quic"] }
|
|
|
|
# `loaded` dlopens libvulkan at runtime (no link-time dependency — GPU-less boxes still
|
|
# start and fail into a clean error; on Windows vulkan-1.dll is a GPU-driver component).
|
|
# `ash` on sdl3 types SDL_Vulkan_CreateSurface with ash 0.38 handles so the surface
|
|
# hands over without transmutes.
|
|
ash = { version = "0.38", features = ["loaded"] }
|
|
|
|
async-channel = "2"
|
|
anyhow = "1"
|
|
tracing = "0.1"
|
|
|
|
# Linux links the system SDL3; Windows builds it from source (same choice as the rest
|
|
# of the workspace's Windows SDL consumers).
|
|
[target.'cfg(target_os = "linux")'.dependencies]
|
|
sdl3 = { version = "0.18", features = ["hidapi", "ash"] }
|
|
|
|
[target.'cfg(windows)'.dependencies]
|
|
sdl3 = { version = "0.18", features = ["hidapi", "ash", "build-from-source"] }
|
|
# Window branding only (win32.rs): the exe-embedded icon onto the SDL window's title
|
|
# bar/taskbar (WM_SETICON) and the shared AppUserModelID for unpackaged runs, so the
|
|
# shell and the session window group as ONE taskbar app across the visibility handoff.
|
|
windows-sys = { version = "0.61", features = [
|
|
"Win32_Foundation",
|
|
"Win32_Storage_Packaging_Appx",
|
|
"Win32_System_LibraryLoader",
|
|
"Win32_UI_Shell",
|
|
"Win32_UI_WindowsAndMessaging",
|
|
] }
|
|
|
|
[features]
|
|
# PyroWave planar present path (the wired-LAN wavelet codec) — forwards to the decode
|
|
# backend in pf-client-core; ON by default, matching pf-client-core's default.
|
|
default = ["pyrowave"]
|
|
pyrowave = ["pf-client-core/pyrowave"]
|
|
|
|
[lints]
|
|
workspace = true
|