enricobuehler
5c05246098
cargo tree -p punktfunk-client-session finds no ffmpeg. The host still does, which is the whole point: pf-encode keeps libavcodec unconditionally and no host workflow, packaging script or licence file was touched. Deleted: crates/pf-ffvk, video_vulkan.rs, video_vaapi.rs, video_libav.rs, the libavcodec half of video_d3d11.rs, the av_log machinery, ffmpeg::codec::Id as the decoder's vocabulary (the quic CODEC_* wire constants now serve, which is why the evidence table was keyed on them), DecodedImage::VkFrame and ::Dmabuf, the presenter's AVVkFrame lane, and the ffmpeg-fallback feature with everything behind it. DrmFrameGuard collapses from an enum to a newtype, which removes an unsafe impl Send. Roughly 25,000 lines. Then the CI, packaging, licensing and docs work the plan's §6 lists: the Windows workflows lose FFMPEG_DIR, PF_FFVK_VULKAN_INCLUDE and their PATH prepend; the MSIX loses its DLL wildcard; the client .deb stops emitting libav sonames on its own because depends come from dpkg-shlibdeps; arch, flatpak and nix drop the dependency; and the README's "FFmpeg 7 or 8" contract narrows to the host. Three defects reached users' machines in the first cut, and none was in the deletion itself. All three desktop Settings UIs offer vulkan, vaapi and d3d11va as stored decoder values, so those strings sit in shipped settings files today. Refusing them by name — which is the correct rule for a stale pin — would have bricked every upgraded client whose owner ever touched that dropdown. They now migrate onto the native rung for the same hardware family, at decoder construction AND at each dialog's lookup, because a legacy value that matches no preset displays as "Automatic" and silently rewrites the user's preference on the next save. M9's evidence filter was deleted on the argument that with no libavcodec twin below, barring an unproven rung removes hardware decode rather than moving down one rung. That is true on Windows and false on Linux for Intel and every unknown vendor id, where prefer_vulkan_first is false and the order is native-vaapi → native-vk: a rung that has decoded nothing anywhere sitting above one that is 250/250 on three drivers. Every Intel Linux desktop would have moved from libavcodec VAAPI, shipping for years, onto pf-vaadec by default — and a rung that constructs and then produces wrong pixels leaves only by the error-streak demotion, which this codebase already documents as not tripping on the B580's strobing. The filter is restored as a narrow, pure, testable rule: an unproven rung yields to a proven one, and to nothing else. Windows deliberately passes no rung below, because that vendor family is the one with a measured wrong-pixel report against Vulkan decode, and trading no evidence for evidence of corruption is the wrong direction. And the notices still said FFmpeg was bundled. The root file is what both desktop clients include_str! and what the MSIX ships, three lines under the new card saying no FFmpeg is bundled; Apple's Acknowledgements said it too, on iOS, tvOS and macOS. The generator now emits four per-client files scoped by transitive closure — 0 FFmpeg mentions in each, verified — while the root file keeps it for the host. That also ends the standing false attribution of ffmpeg-next, GTK4, windows-rs and the NVENC SDK to an iPhone. Windows has no reachable box, so it was compiled instead: a cross clippy at -D warnings on x86_64 and aarch64-pc-windows-msvc with the C toolchain stubbed so build scripts run without linking. That gate immediately caught an include_str! path one directory too deep, which nothing else could have. Gates: container clippy -D warnings, 160 tests, workspace check, both Windows targets clean, client ffmpeg count 0 and host 2. The four decode crates are untouched, so the hardware rungs' 250/250 stands. ⚠ Owed and unrun: no GPU has executed any of this milestone. M8's on-glass software check, M7's D3D11 and VAAPI AV1 hardware legs, and M9's field bake all still want hardware, and the bake window and criteria remain the user's.
43 lines
2.1 KiB
Plaintext
43 lines
2.1 KiB
Plaintext
FFmpeg — third-party component notice
|
|
=====================================
|
|
|
|
This product bundles unmodified shared libraries from the FFmpeg project
|
|
(avcodec / avutil / avformat / swscale / swresample and their dependencies) as
|
|
separate dynamic-link libraries (DLLs). punktfunk uses them only for hardware
|
|
video encode (AMD AMF / Intel QSV) in the streaming host. The punktfunk client
|
|
bundles no FFmpeg libraries at all — it decodes with its own native decoders —
|
|
so this notice concerns the host installer only.
|
|
|
|
License
|
|
-------
|
|
The bundled FFmpeg libraries are distributed under the GNU Lesser General Public
|
|
License (LGPL), version 2.1 or later. The bundled builds are the "lgpl-shared"
|
|
configuration — they do NOT include any GPL-licensed components (notably they do
|
|
not include libx264 or libx265; punktfunk does not use them). The full text of
|
|
the LGPL accompanies this notice (see the COPYING.LGPLv2.1 / LICENSE files in
|
|
this directory; if absent, see https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html).
|
|
|
|
How punktfunk complies (dynamic linking)
|
|
----------------------------------------
|
|
punktfunk links FFmpeg only dynamically: the FFmpeg DLLs are shipped as separate
|
|
files alongside the application and are not statically combined into the
|
|
punktfunk executable. You may replace these DLLs with your own ABI-compatible
|
|
build of FFmpeg, which satisfies LGPL section 6 (the right to relink the work
|
|
against a modified version of the library).
|
|
|
|
Source code
|
|
-----------
|
|
The bundled binaries are unmodified builds produced by the BtbN/FFmpeg-Builds
|
|
project. The exact source for the FFmpeg release used is available from:
|
|
|
|
* FFmpeg project source: https://ffmpeg.org/download.html (release n7.1)
|
|
* Exact build recipe: https://github.com/BtbN/FFmpeg-Builds
|
|
|
|
A copy of the corresponding FFmpeg source for the version shipped here is
|
|
available on request from the punktfunk maintainers (https://git.unom.io/unom/punktfunk).
|
|
|
|
Trademark
|
|
---------
|
|
FFmpeg is a trademark of Fabrice Bellard, originator of the FFmpeg project.
|
|
punktfunk is not affiliated with or endorsed by the FFmpeg project.
|