fix(client-core): pad-audio references the WASAPI module by its mounted name #57

Merged
enricobuehler merged 1 commits from fix/pad-audio-wasapi-module-path into main 2026-08-05 06:22:33 +00:00
Owner

Main's Windows build has been red since the pad-audio merge (#23): pad_audio.rs:926 calls crate::audio_wasapi::device_by_id, but lib.rs mounts audio_wasapi.rs as crate::audio via the #[path] per-OS swap — the audio_wasapi module name never exists. The call site is Windows-gated, so every Linux leg stayed green while both windows / build targets failed E0433 (and the msix packages with them).

One-line rename to the mounted path, plus the comment that pointed readers at the phantom name. Verification = this PR's own windows leg (the path compiles on no other platform).

Unblocks PR #53, whose identical windows failures are this breakage on the base commit.

Main's Windows build has been red since the pad-audio merge (#23): `pad_audio.rs:926` calls `crate::audio_wasapi::device_by_id`, but lib.rs mounts `audio_wasapi.rs` **as `crate::audio`** via the `#[path]` per-OS swap — the `audio_wasapi` module name never exists. The call site is Windows-gated, so every Linux leg stayed green while both `windows / build` targets failed E0433 (and the msix packages with them). One-line rename to the mounted path, plus the comment that pointed readers at the phantom name. Verification = this PR's own windows leg (the path compiles on no other platform). Unblocks PR #53, whose identical windows failures are this breakage on the base commit.
enricobuehler added 1 commit 2026-08-05 06:15:22 +00:00
fix(client-core): pad-audio references the WASAPI module by its mounted name
ci / web (pull_request) Successful in 56s
apple / swift (pull_request) Successful in 1m25s
apple / screenshots (pull_request) Skipped
windows / build (aarch64-pc-windows-msvc) (pull_request) Successful in 1m40s
ci / docs-site (pull_request) Successful in 2m33s
ci / rust-arm64 (pull_request) Successful in 2m43s
windows / build (x86_64-pc-windows-msvc) (pull_request) Successful in 2m17s
android / android (pull_request) Successful in 4m12s
ci / rust (pull_request) Successful in 6m21s
56adb47026
The Windows build of pf-client-core has been red on main since the
pad-audio merge (#23): pad_audio.rs calls
`crate::audio_wasapi::device_by_id`, but lib.rs mounts audio_wasapi.rs AS
`crate::audio` via the #[path] per-OS swap — the `audio_wasapi` module
name never exists. Windows-gated call site, so every Linux leg stayed
green while both `windows / build` targets failed E0433.

One-line rename to the mounted path (+ the comment that pointed readers
at the phantom name). Verification is the PR's own windows leg — the
crate builds on no other platform this path compiles on.
enricobuehler merged commit 9dfbc2f895 into main 2026-08-05 06:22:33 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unom/punktfunk#57