docs(writing): sweep crate comments to house style #514

Merged
enricobuehler merged 31 commits from luxus/punktfunk:docs/comment-sweep into main 2026-09-02 00:18:26 +00:00
Member

Comments in first-party crates were self-discussion: plan sections, review tickets, soaks, recap of the next five lines. House style keeps the live invariant.

This PR:

  • Teaches comment voice in docs/writing.md (present tense, not archaeology, not a poem). Length CI stays a backstop.
  • Adds /comment-sweep and /comment-sweep-all (one commit per crate; review_only after a crash).
  • Rewrites comments crate by crate. // SAFETY: stays a proof. Vendor sys crates and **/vendor/** are out of scope.

Rebased onto current unom/main. Where main had landed real code (capture CCD keys, installer wizard), those hunks kept main.

User-facing fact changed? n/a.

Comments in first-party crates were self-discussion: plan sections, review tickets, soaks, recap of the next five lines. House style keeps the live invariant. This PR: - Teaches comment voice in `docs/writing.md` (present tense, not archaeology, not a poem). Length CI stays a backstop. - Adds `/comment-sweep` and `/comment-sweep-all` (one commit per crate; `review_only` after a crash). - Rewrites comments crate by crate. `// SAFETY:` stays a proof. Vendor sys crates and `**/vendor/**` are out of scope. Rebased onto current `unom/main`. Where main had landed real code (capture CCD keys, installer wizard), those hunks kept main. User-facing fact changed? n/a.
luxus added 30 commits 2026-09-02 00:14:58 +00:00
House style caps comments, but the tree is still full of
plan-section novels. A per-crate sweep is the way through.
One run rewrites one crate, reviews every file, one commit.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
A session can only host four workflow runs, so one crate per
run cannot fan out. One run rewrites every crate in parallel
and still commits them one at a time.
Comments in this crate were self-discussion: plan sections, review tickets,
and recap of the next lines. House style keeps the trap and the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Length CI catches novels. Models still write archaeology and poems
inside the cap. The rulebook has to show the present-tense invariant.
A crash killed the all-crates run after rewrite. review_only
skips the 402 batches and starts at coverage.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
docs(punktfunk-tray): tighten comments to house style
setup-windows / test (pull_request) Skipped
windows-client / client (arm64, --no-default-features, aarch64-pc-windows-msvc, C:\t-a64) (pull_request) Skipped
windows-client / client (x64, , x86_64-pc-windows-msvc, C:\t) (pull_request) Skipped
windows-drivers / probe-and-proto (pull_request) Skipped
windows-drivers / driver-build (pull_request) Skipped
android / android (pull_request) Canceled after 0s
apple / swift (pull_request) Canceled after 0s
apple / distribute (pull_request) Canceled after 0s
apple / screenshots (pull_request) Canceled after 0s
ci / rust (pull_request) Canceled after 0s
ci / rust-arm64 (pull_request) Canceled after 0s
ci / web (pull_request) Canceled after 0s
ci / docs-site (pull_request) Canceled after 0s
ci / bun-nix (pull_request) Canceled after 0s
ci / docs-drift (pull_request) Canceled after 0s
installer-smoke / smoke (arch) (pull_request) Canceled after 0s
installer-smoke / build punktfunk-setup (musl) (pull_request) Canceled after 0s
installer-smoke / omarchy integration self-check (pull_request) Canceled after 0s
installer-smoke / omarchy (armed update guard) (pull_request) Canceled after 0s
installer-smoke / smoke (debian-13) (pull_request) Canceled after 0s
installer-smoke / smoke (fedora-44) (pull_request) Canceled after 0s
macos-host / check (pull_request) Canceled after 0s
setup-binary / build (aarch64) (pull_request) Canceled after 0s
setup-binary / build (x86_64) (pull_request) Canceled after 0s
setup-binary / probe the published channel (pull_request) Canceled after 0s
setup-binary / publish to the generic registry (pull_request) Canceled after 0s
secret-scan / gitleaks (pull_request) Successful in 38s
ad41ca94f2
Comments in this crate were self-discussion: plan sections, review
tickets, and recap of the next lines. House style keeps the trap and
the number.
luxus force-pushed docs/comment-sweep from e6385090b3 to ad41ca94f2 2026-09-02 00:14:58 +00:00 Compare
luxus added 1 commit 2026-09-02 00:16:29 +00:00
chore(writing): drop comment-sweep workflows from the PR
macos-host / check (pull_request) Skipped
apple / swift (pull_request) Skipped
apple / distribute (pull_request) Skipped
apple / screenshots (pull_request) Skipped
setup-windows / test (pull_request) Skipped
windows-client / client (arm64, --no-default-features, aarch64-pc-windows-msvc, C:\t-a64) (pull_request) Skipped
windows-client / client (x64, , x86_64-pc-windows-msvc, C:\t) (pull_request) Skipped
windows-drivers / probe-and-proto (pull_request) Skipped
windows-drivers / driver-build (pull_request) Skipped
android / android (pull_request) Failing after 4m18s
ci / web (pull_request) Successful in 1m10s
ci / rust-arm64 (pull_request) Failing after 1m38s
ci / bun-nix (pull_request) Successful in 35s
ci / docs-drift (pull_request) Failing after 50s
installer-smoke / omarchy integration self-check (pull_request) Successful in 15s
secret-scan / gitleaks (pull_request) Successful in 2m35s
installer-smoke / build punktfunk-setup (musl) (pull_request) Successful in 4m17s
setup-binary / build (aarch64) (pull_request) Successful in 4m5s
ci / rust (pull_request) Failing after 8m9s
ci / docs-site (pull_request) Successful in 8m26s
setup-binary / build (x86_64) (pull_request) Successful in 11m26s
setup-binary / probe the published channel (pull_request) Skipped
setup-binary / publish to the generic registry (pull_request) Skipped
installer-smoke / omarchy (armed update guard) (pull_request) Successful in 1m48s
installer-smoke / smoke (arch) (pull_request) Successful in 1m49s
installer-smoke / smoke (fedora-44) (pull_request) Successful in 1m45s
installer-smoke / smoke (debian-13) (pull_request) Successful in 17m57s
848905a769
The sweep already landed as crate commits. The orchestration
scripts do not belong on this branch.
enricobuehler merged commit f28cbf1c4c into main 2026-09-02 00:18:26 +00:00
enricobuehler deleted branch docs/comment-sweep 2026-09-02 00:18:30 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unom/punktfunk#514