Edition-2024 follow-up: the three gates only the PR's own CI could reach #180

Merged

enricobuehler merged 2 commits from worktree-edition-2024 into main 2026-08-12 16:34:14 +00:00

Conversation 0 Commits 2 Files Changed 5

+35 -20

enricobuehler commented 2026-08-12 15:45:19 +00:00

Owner

Copy Link

Copy Source

#177 merged at c68e0be6, moments before this one-commit follow-up landed on the branch — without it, main's CI is red on the unsafe-hygiene gates and the aarch64 clippy leg. The three fixes, each a gate no local box run could reach:

• Gate B (check-unsafe-hygiene.sh): adl_emul.rs's adl_malloc had a reachable .expect inside an unsafe extern "C" fn — a panic there is an abort across the extern boundary. Now panic-free: the Err arm (unreachable in practice — size ≤ i32::MAX can't overflow the layout) returns null, which ADL treats as an ordinary allocator failure. This came in with #175/#176 and is why main's own push CI was already red before the edition merge.
• Gate C: the textual ratchet counts comments too — the new forbid carve-out comments in punktfunk-host/src/main.rs literally said env::set_var, putting the file 2 over its baseline of 0. Reworded to "mutating the process env".
• aarch64 leg: clients/linux is forbid(unsafe_code) crate-wide, and the arm64 cross image is the only CI leg that compiles it (the .25 box lacks glib-2.0 dev). Its two env mutations — clearing Steam's SDL device filter at startup and the spawn test's HOME scoping — are unsafe calls in edition 2024, and forbid can't be locally allowed. Demoted to deny with two named #[allow] exemptions carrying the SAFETY proofs (the pf-update pattern); everything else stays compiler-refused.

Verified locally: hygiene script all-gates-clean, cargo fmt --all --check, and check of the touched crates.

#177 merged at `c68e0be6`, moments before this one-commit follow-up landed on the branch — without it, main's CI is red on the unsafe-hygiene gates and the aarch64 clippy leg. The three fixes, each a gate no local box run could reach: - **Gate B** (`check-unsafe-hygiene.sh`): `adl_emul.rs`'s `adl_malloc` had a reachable `.expect` inside an `unsafe extern "C" fn` — a panic there is an abort across the extern boundary. Now panic-free: the `Err` arm (unreachable in practice — `size ≤ i32::MAX` can't overflow the layout) returns null, which ADL treats as an ordinary allocator failure. This came in with #175/#176 and is why main's own push CI was already red before the edition merge. - **Gate C**: the textual ratchet counts *comments* too — the new `forbid` carve-out comments in `punktfunk-host/src/main.rs` literally said `env::set_var`, putting the file 2 over its baseline of 0. Reworded to "mutating the process env". - **aarch64 leg**: `clients/linux` is `forbid(unsafe_code)` crate-wide, and the arm64 cross image is the only CI leg that compiles it (the .25 box lacks glib-2.0 dev). Its two env mutations — clearing Steam's SDL device filter at startup and the spawn test's `HOME` scoping — are unsafe calls in edition 2024, and `forbid` can't be locally allowed. Demoted to `deny` with two named `#[allow]` exemptions carrying the SAFETY proofs (the pf-update pattern); everything else stays compiler-refused. Verified locally: hygiene script all-gates-clean, `cargo fmt --all --check`, and check of the touched crates.

enricobuehler added 1 commit 2026-08-12 15:45:23 +00:00

fix(ci): the gates the PR run reaches and the boxes could not ... 017867f211

- adl_emul.rs adl_malloc: panic-free (a reachable expect in an extern fn is an
  abort — gate B; the Err arm is unreachable, ADL treats null as failure)
- punktfunk-host main.rs: reword the carve-out comments so gate C's textual
  count stays at its baseline (comments count)
- clients/linux: forbid(unsafe_code) -> deny with two named allows — the SDL
  device-filter clear and the spawn test's HOME scoping are unsafe calls in
  edition 2024 (caught by the aarch64 leg, the only one with glib)

enricobuehler added 1 commit 2026-08-12 16:32:03 +00:00

Merge remote-tracking branch 'origin/main' into worktree-edition-2024 57703fe31c

enricobuehler merged commit 5f55b820bc into main 2026-08-12 16:34:14 +00:00

enricobuehler referenced this issue from a commit 2026-08-12 16:48:09 +00:00

fix(clients/session): the edition-2024 session bin cannot build on Windows

enricobuehler referenced this pull request 2026-08-12 16:48:33 +00:00

An over-declared HEVC level no longer demotes native Vulkan decode, and the Windows client legs build again #181

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

FernandoMX enricobuehler (Enrico Bühler) kszlim nannku neoney sassycrown

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unom/punktfunk#180