From d59de1553fa8e1a7a25fc40c71e95e0c5a5f31ae Mon Sep 17 00:00:00 2001 From: enricobuehler Date: Fri, 19 Jun 2026 12:22:00 +0000 Subject: [PATCH] fix(packaging/windows): make the .iss pure ASCII (ISCC encoding failure) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The smoke-test diagnostic proved Inno itself is healthy (a trivial ASCII script compiled), while the real .iss died before the "Compiler engine version" line — i.e. at script open, not during compile. The difference: the real .iss was UTF-8 with non-ASCII chars (→, —) in comments, which ISCC 6.4+ rejects without a UTF-8 BOM (and the German-locale runner misreads). Replace them with ASCII (->, -). Co-Authored-By: Claude Opus 4.8 (1M context) --- packaging/windows/punktfunk-host.iss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packaging/windows/punktfunk-host.iss b/packaging/windows/punktfunk-host.iss index b749220..d6e4cf3 100644 --- a/packaging/windows/punktfunk-host.iss +++ b/packaging/windows/punktfunk-host.iss @@ -3,8 +3,8 @@ ; Produces a signed setup.exe that lays the host into Program Files, optionally installs the bundled ; SudoVDA virtual-display driver, and DELEGATES service registration to `punktfunk-host service ; install`. The real, idempotent install logic (SCM registration, firewall rules, default host.env, -; the SYSTEM→interactive-session CreateProcessAsUserW supervisor for secure-desktop capture) lives in -; crates/punktfunk-host/src/service.rs — this script does NOT duplicate it. That SYSTEM service model +; the SYSTEM->interactive-session CreateProcessAsUserW supervisor for secure-desktop capture) lives in +; crates/punktfunk-host/src/service.rs - this script does NOT duplicate it. That SYSTEM service model ; is exactly why MSIX is unusable here and we ship a classic elevated installer instead. ; ; Built by pack-host-installer.ps1, e.g.: @@ -80,7 +80,7 @@ Filename: "powershell.exe"; \ StatusMsg: "Installing the SudoVDA virtual display driver..."; \ Flags: runhidden waituntilterminated; Tasks: installdriver #endif -; Register (or re-point, on upgrade — idempotent) the SYSTEM service from its FINAL {app} location: +; Register (or re-point, on upgrade - idempotent) the SYSTEM service from its FINAL {app} location: ; service install records current_exe() as the SCM binPath, so it must run from {app}, not {tmp}. Filename: "{app}\punktfunk-host.exe"; Parameters: "service install"; WorkingDir: "{app}"; \ StatusMsg: "Registering the punktfunk host service..."; Flags: runhidden waituntilterminated