From cc8cccbee61959220f93578b23a2aea72888e125 Mon Sep 17 00:00:00 2001 From: enricobuehler Date: Fri, 24 Jul 2026 02:07:12 +0200 Subject: [PATCH] fix(core/client): drop two redundant glob imports that warned on tvOS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `punktfunk-core` emitted `unused import: super::super::*` for client/pump/handshake.rs and client/pump/input_task.rs — but only when built for a tvOS target, where the cfg set leaves the glob contributing nothing. Nobody saw them because CI never builds tvOS: that needs BUILD_TVOS=1 and the Tier-3 build-std nightly path, and the Apple workflow only runs swift build/test (macOS). Both files also `use super::*`, i.e. the parent `pump` module, which itself globs `super::*` (`client`) unconditionally — so every name stays reachable by that path and the inner glob was pure duplication. Their sibling datagram_task.rs already imports only `use super::*`, so this also makes the module consistent. control_task.rs and data.rs keep theirs: those genuinely resolve names through it and never warned. Verified warning-free AND compiling on every slice the xcframework ships — aarch64/x86_64-apple-darwin, aarch64-apple-ios, aarch64-apple-ios-sim, aarch64-apple-tvos, aarch64-apple-tvos-sim, x86_64-apple-tvos — plus Linux with and without the `quic` feature. A full xcframework rebuild now reports 0 warnings (was 6: two per tvOS slice), and swift build, swift test (170 tests), and xcodebuild for the macOS, iOS and tvOS schemes all pass. Co-Authored-By: Claude Fable 5 --- crates/punktfunk-core/src/client/pump/handshake.rs | 1 - crates/punktfunk-core/src/client/pump/input_task.rs | 1 - 2 files changed, 2 deletions(-) diff --git a/crates/punktfunk-core/src/client/pump/handshake.rs b/crates/punktfunk-core/src/client/pump/handshake.rs index 4b5a7f94..f6a6c98b 100644 --- a/crates/punktfunk-core/src/client/pump/handshake.rs +++ b/crates/punktfunk-core/src/client/pump/handshake.rs @@ -3,7 +3,6 @@ //! up the data-plane [`Session`]. A typed application close from the host surfaces as //! [`PunktfunkError::Rejected`] instead of the generic transport error. -use super::super::*; use super::*; /// Everything [`run_pump`](super::run_pump) needs from a successful connect + handshake. diff --git a/crates/punktfunk-core/src/client/pump/input_task.rs b/crates/punktfunk-core/src/client/pump/input_task.rs index 9c75f45a..8bcbc5a0 100644 --- a/crates/punktfunk-core/src/client/pump/input_task.rs +++ b/crates/punktfunk-core/src/client/pump/input_task.rs @@ -9,7 +9,6 @@ //! Keyboard/mouse/touch events pass through unchanged; an older host (no caps bit) keeps //! getting the legacy per-transition gamepad events. -use super::super::*; use super::*; pub(super) async fn run(