From bf9be59f0b462a01dce9d3441466a96caee0746c Mon Sep 17 00:00:00 2001 From: enricobuehler Date: Thu, 9 Jul 2026 01:06:43 +0200 Subject: [PATCH] feat(clients/windows): rename the Help button to Shortcuts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "Shortcuts" says what the page actually is — the in-stream keyboard/controller reference — and the keyboard glyph reads better than the generic help icon (user feedback from the live-test round). Page title follows. Co-Authored-By: Claude Fable 5 --- clients/windows/src/app/help.rs | 17 +++++++++-------- clients/windows/src/app/hosts.rs | 2 +- clients/windows/src/app/mod.rs | 4 ++-- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/clients/windows/src/app/help.rs b/clients/windows/src/app/help.rs index 03fc282f..949ea8c5 100644 --- a/clients/windows/src/app/help.rs +++ b/clients/windows/src/app/help.rs @@ -1,7 +1,8 @@ -//! The Help screen: a short note on the in-stream capture model plus a reference of the keyboard -//! shortcuts — reached from the Help button on the host list. The Windows counterpart of the GTK -//! client's Keyboard Shortcuts window; the bindings themselves live in [`crate::input`], so both -//! clients document the same set. +//! The Shortcuts screen: a short note on the in-stream capture model plus a reference of the +//! keyboard shortcuts — reached from the Shortcuts button on the host list. The Windows +//! counterpart of the GTK client's Keyboard Shortcuts window; the bindings themselves live in +//! the session window (and [`crate::input`] for the legacy builtin path), so both clients +//! document the same set. use super::style::*; use super::Screen; @@ -65,9 +66,9 @@ fn shortcuts_reference() -> Element { .into() } -/// The Help screen: a `page`-column with a Back button to the host list, an intro card on the -/// capture model, and the shortcuts reference. Hook-free — called inline from `root` like the -/// other static screens. +/// The Shortcuts screen: a `page`-column with a Back button to the host list, an intro card on +/// the capture model, and the shortcuts reference. Hook-free — called inline from `root` like +/// the other static screens. pub(crate) fn help_page(set_screen: &AsyncSetState) -> Element { let back_btn = button("Back").accent().icon(Symbol::Back).on_click({ let ss = set_screen.clone(); @@ -90,7 +91,7 @@ pub(crate) fn help_page(set_screen: &AsyncSetState) -> Element { ); page(vec![ - page_header("Help", back_btn), + page_header("Shortcuts", back_btn), intro.into(), shortcuts_reference(), ]) diff --git a/clients/windows/src/app/hosts.rs b/clients/windows/src/app/hosts.rs index 76acc17e..f22e74ba 100644 --- a/clients/windows/src/app/hosts.rs +++ b/clients/windows/src/app/hosts.rs @@ -292,7 +292,7 @@ pub(crate) fn hosts_page(props: &HostsProps, cx: &mut RenderCx) -> Element { let sa = set_show_add.clone(); move || sa.call(true) }), - header_btn("Help", Symbol::Help).on_click({ + header_btn("Shortcuts", Symbol::Keyboard).on_click({ let ss = set_screen.clone(); move || ss.call(Screen::Help) }), diff --git a/clients/windows/src/app/mod.rs b/clients/windows/src/app/mod.rs index e88944de..4ec12086 100644 --- a/clients/windows/src/app/mod.rs +++ b/clients/windows/src/app/mod.rs @@ -62,8 +62,8 @@ pub(crate) enum Screen { Settings, /// Open-source / third-party license notices (reached from Settings). Licenses, - /// In-stream keyboard-shortcuts reference + capture help (reached from the host list's Help - /// button). + /// In-stream keyboard-shortcuts reference + capture help (reached from the host list's + /// Shortcuts button). Help, Pair, /// Per-host network speed test (probe burst + recommended bitrate).