From a95b518ef3299608b551575518faebce5f98ef7c Mon Sep 17 00:00:00 2001 From: enricobuehler Date: Sun, 12 Jul 2026 02:46:45 +0200 Subject: [PATCH] fix(windows): show app version on About screen + capitalize Punktfunk on licenses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The About settings card had no version at all — add an identity block (app name + "Version ", the workspace version) at the top, the WinUI Settings convention and matching the Apple client's "Version X" wording. Also capitalize the brand name on the licenses screen (was lowercase "punktfunk"). Verified against the pinned windows-reactor source + cargo fmt --check; full Windows link left to CI (Windows-only crate). Co-Authored-By: Claude Opus 4.8 --- clients/windows/src/app/licenses.rs | 2 +- clients/windows/src/app/settings.rs | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/clients/windows/src/app/licenses.rs b/clients/windows/src/app/licenses.rs index b58faafb..cbe8127b 100644 --- a/clients/windows/src/app/licenses.rs +++ b/clients/windows/src/app/licenses.rs @@ -23,7 +23,7 @@ pub(crate) fn licenses_page(set_screen: &AsyncSetState) -> Element { let app_card = card( vstack(( - text_block("punktfunk").font_size(15.0).semibold(), + text_block("Punktfunk").font_size(15.0).semibold(), text_block("Licensed under MIT OR Apache-2.0, at your option.") .font_size(12.0) .wrap() diff --git a/clients/windows/src/app/settings.rs b/clients/windows/src/app/settings.rs index 8cde457d..55d9eadb 100644 --- a/clients/windows/src/app/settings.rs +++ b/clients/windows/src/app/settings.rs @@ -369,6 +369,16 @@ pub(crate) fn settings_page( "Adds \u{201C}Browse library\u{2026}\u{201D} to paired hosts \u{2014} pick a game and it \ launches in the stream. Mirrors the Apple client's toggle.", ); + // App identity + version at the top of the About card (the WinUI Settings convention; the About + // screen previously showed no version at all). CARGO_PKG_VERSION is the workspace version, baked + // in at compile time. + let about_identity = vstack(( + text_block("Punktfunk").font_size(20.0).semibold(), + text_block(concat!("Version ", env!("CARGO_PKG_VERSION"))) + .font_size(12.0) + .foreground(ThemeRef::SecondaryText), + )) + .spacing(2.0); // The selected section's content — per-control guidance lives on hover tooltips, so the // card is just the controls. @@ -403,7 +413,11 @@ pub(crate) fn settings_page( ), "about" => ( "About", - settings_card(vec![library_toggle.into(), licenses_button.into()]), + settings_card(vec![ + about_identity.into(), + library_toggle.into(), + licenses_button.into(), + ]), ), _ => ( "Display",