chore(cleanup): drop TEMP cursor probes + clear KWin-leg clippy debt

The KWin/Phase-A/B commits were built but never clippy-checked (that distrobox had no clippy component), so they left TEMP on-glass probes and lint debt in the tree. With clippy now runnable (fedora rust 1.96.1 = CI parity): - drop the `fec424ee`/`8cff30d5` TEMP probes: the `update_cursor_meta` SPA_META diagnostic logs (also un-detaches the `// SAFETY:` comment from its `unsafe` block → fixes `undocumented_unsafe_blocks`) and the KWin composite-arm probe in the encode loop. - `#[allow(clippy::too_many_arguments)]` on `spawn_pipewire` (8 params since the KWin leg added `expect_exact_dims`; mirrors `from_virtual_output`). clippy `-p pf-capture -p pf-vdisplay -p punktfunk-host --locked --features nvenc,vulkan-encode -- -D warnings` is now green. (--all-targets additionally trips a pre-existing env mismatch: the fedora libspa binding lacks `SPA_VIDEO_TRANSFER_SMPTE2084`, referenced only by a `#[cfg(test)]` guard-test — not a code issue; CI's pinned pipewire has it.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-22 23:54:56 +02:00
parent 7058647264
commit 92f38ec3dd
4 changed files with 9 additions and 65 deletions
@@ -2110,34 +2110,6 @@ pub(super) fn virtual_stream(ctx: SessionContext, prepared: Option<PreparedDispl
                if let Some(live) = capturer.cursor() {
                    frame.cursor = Some(live);
                }
-                // TEMP KWin composite probe (DROP BEFORE MERGE): what the composite arm actually
-                // hands the encoder — on-glass the blend module loads yet nothing draws, so the
-                // open question is whether an overlay reaches the frame at all.
-                #[cfg(not(target_os = "windows"))]
-                {
-                    use std::sync::atomic::{AtomicU64, Ordering as ProbeOrd};
-                    static PROBE_COMPOSITE: AtomicU64 = AtomicU64::new(0);
-                    let n = PROBE_COMPOSITE.fetch_add(1, ProbeOrd::Relaxed) + 1;
-                    if n == 1 || n % 512 == 0 {
-                        match frame.cursor.as_ref() {
-                            Some(c) => tracing::info!(
-                                n,
-                                x = c.x,
-                                y = c.y,
-                                w = c.w,
-                                h = c.h,
-                                visible = c.visible,
-                                serial = c.serial,
-                                "composite probe: overlay riding to the encoder"
-                            ),
-                            None => tracing::info!(
-                                n,
-                                "composite probe: NO overlay on the frame (capturer.cursor() None \
-                                 and no frame-attached overlay)"
-                            ),
-                        }
-                    }
-                }
            }
        } else if gamescope_composite {
            // gamescope (Phase C): no channel, host always composites. Refresh the (repeat or new)