From 8672026e9722af8b38b0be55a6e1a303690c4889 Mon Sep 17 00:00:00 2001 From: enricobuehler Date: Sun, 28 Jun 2026 21:38:07 +0000 Subject: [PATCH] fix(host): clear clippy doc_lazy_continuation in the 4:4:4 docs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A line-wrap put `+`/`*`-style markers at the start of two doc lines, which clippy (Windows host job, rust 1.96) reads as markdown list items whose unindented follow-on lines trip `doc_lazy_continuation` under `-D warnings`: - encode/windows/nvenc.rs `chroma_444` field doc (the failing Windows-host clippy job): "+ chromaFormatIDC = 3" → "and chromaFormatIDC = 3". - encode/linux/vaapi.rs `probe_can_encode_444` doc: "+ validate" → "and validate" (last line, didn't fire yet, but fragile — fixed pre-emptively). Pure doc rewording, no behaviour change. Co-Authored-By: Claude Opus 4.8 --- crates/punktfunk-host/src/encode/linux/vaapi.rs | 2 +- crates/punktfunk-host/src/encode/windows/nvenc.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/punktfunk-host/src/encode/linux/vaapi.rs b/crates/punktfunk-host/src/encode/linux/vaapi.rs index 7115bdc..ce96b29 100644 --- a/crates/punktfunk-host/src/encode/linux/vaapi.rs +++ b/crates/punktfunk-host/src/encode/linux/vaapi.rs @@ -166,7 +166,7 @@ pub fn probe_can_encode(codec: Codec) -> bool { /// validated hardware to build + verify the 4:4:4 surface/profile path against. Returning `false` /// keeps the negotiation honest: a VAAPI host resolves every session to 4:2:0 before the Welcome, so /// the client never builds a 4:4:4 decoder it would only get 4:2:0 frames for. (Follow-up: implement -/// + validate on an Intel Arc / RDNA4-class box that advertises a HEVC 4:4:4 encode entrypoint.) +/// and validate on an Intel Arc / RDNA4-class box that advertises a HEVC 4:4:4 encode entrypoint.) pub fn probe_can_encode_444(_codec: Codec) -> bool { tracing::info!("VAAPI HEVC 4:4:4 encode is not implemented yet — declining (encoding 4:2:0)"); false diff --git a/crates/punktfunk-host/src/encode/windows/nvenc.rs b/crates/punktfunk-host/src/encode/windows/nvenc.rs index 529626e..018d116 100644 --- a/crates/punktfunk-host/src/encode/windows/nvenc.rs +++ b/crates/punktfunk-host/src/encode/windows/nvenc.rs @@ -58,8 +58,8 @@ pub struct NvencD3d11Encoder { /// Encoded bit depth (8 or 10). 10 → HEVC Main10 (NVENC upconverts the 8-bit ARGB input). bit_depth: u8, /// Full-chroma 4:4:4 (HEVC Range Extensions, `chroma_format_idc = 3`) requested for this session. - /// NVENC ingests the RGB (ARGB/ABGR10) input and CSCs it to YUV444 internally — the `FREXT` profile - /// + `chromaFormatIDC = 3` in the encode config carry the chroma. Gated on the GPU's + /// NVENC ingests the RGB (ARGB/ABGR10) input and CSCs it to YUV444 internally; the `FREXT` profile + /// and `chromaFormatIDC = 3` in the encode config carry the chroma. Gated on the GPU's /// `NV_ENC_CAPS_SUPPORT_YUV444_ENCODE` (cleared in `query_caps` on a card that lacks it) and on an /// RGB input format (NV12/P010 capture can't reconstruct 4:4:4). HEVC-only. chroma_444: bool,