fix(core): let CODEC_PYROWAVE survive the Welcome decode whitelist

Found by the first live session on .21: the host negotiated PyroWave and put codec=8 on the wire, but Welcome::decode's codec whitelist (H264/AV1, else HEVC — the corrupt-byte guard) folded it to HEVC, so the client opened an FFmpeg HEVC decoder against wavelet AUs. Roundtrip test now pins the pyrowave byte (and that a genuinely unknown future bit still folds to the HEVC default). With the fix the Phase-2 exit session runs END TO END on .21 (host + session client on one box, host capturing the GNOME virtual display, client presenting into a headless weston): negotiated codec=PyroWave (adv 0x0f) → PyroWave encoder (CPU-capture path — this box's Mutter+NVIDIA rejects the LINEAR-dmabuf offer) → wire → PyroWave decoder on the presenter's device → planar CSC. Static desktop: stable 60 fps, e2e 2.1-4.1 ms p50 (p95 <= 6 ms), decode 0.2-0.6 ms, vs HEVC/NVENC-direct baseline 2.1 ms — parity at idle. Full-window motion: 60 fps at ~80 Mb/s all-intra (HEVC ~7), decode still sub-ms, zero decode errors or keyframe-request chatter across every run. Deeper motion/loss characterization needs a dmabuf-accepting host box (this one is capped by the CPU capture path). Also retires the stale "no shipping client decodes this" wording in the host encoder/dispatch logs — the negotiation exists now. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-15 09:09:39 +02:00
parent eb8a659319
commit 719b1ef403
4 changed files with 45 additions and 5 deletions
@@ -124,6 +124,45 @@ fn codec_negotiation_and_back_compat() {
        resolve_codec(CODEC_HEVC | CODEC_PYROWAVE, CODEC_HEVC, CODEC_PYROWAVE),
        Some(CODEC_HEVC)
    );
+    // And the negotiated bit SURVIVES the Welcome wire roundtrip — the decode whitelist
+    // once folded unknown codec bytes (incl. PyroWave) to HEVC, which sent wavelet AUs
+    // into an FFmpeg HEVC decoder on the first on-glass run.
+    let mut pw_w = Welcome::decode(
+        &Welcome {
+            abi_version: 2,
+            udp_port: 1,
+            mode: Mode {
+                width: 1280,
+                height: 720,
+                refresh_hz: 60,
+            },
+            fec: FecConfig {
+                scheme: FecScheme::Gf16,
+                fec_percent: 0,
+                max_data_per_block: 1024,
+            },
+            shard_payload: 1024,
+            encrypt: false,
+            key: [0; 16],
+            salt: [0; 4],
+            frames: 0,
+            compositor: CompositorPref::Auto,
+            gamepad: GamepadPref::Auto,
+            bitrate_kbps: 0,
+            bit_depth: 8,
+            color: ColorInfo::SDR_BT709,
+            chroma_format: CHROMA_IDC_420,
+            audio_channels: 2,
+            codec: CODEC_PYROWAVE,
+            host_caps: 0,
+        }
+        .encode(),
+    )
+    .unwrap();
+    assert_eq!(pw_w.codec, CODEC_PYROWAVE);
+    // A genuinely unknown future bit still folds to the HEVC default.
+    pw_w.codec = 0x40;
+    assert_eq!(Welcome::decode(&pw_w.encode()).unwrap().codec, CODEC_HEVC);

    // A Hello advertising codecs roundtrips, and the wire form of a codec-only Hello decodes on
    // a build that ignores the trailing byte (back-compat: extra bytes are skipped).