From 6c4ba77606cf4d31762acffc3a51696aa810afb6 Mon Sep 17 00:00:00 2001 From: enricobuehler Date: Sat, 4 Jul 2026 12:02:45 +0000 Subject: [PATCH] =?UTF-8?q?fix(wol):=20clippy=20+=20cfg-gate=20the=20Windo?= =?UTF-8?q?ws=20client=20module=20=E2=80=94=20main=20compiles=20again?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Wake-on-LAN batch landed with lints that fail `clippy -D warnings` (doc continuation, char-array split, io::Error::other, redundant closure) and an ungated `mod wol;` in the Windows client, which pulls windows-only crates into the non-Windows stub build. Co-Authored-By: Claude Fable 5 --- clients/android/native/src/wol.rs | 2 +- clients/windows/src/main.rs | 1 + crates/punktfunk-core/src/wol.rs | 8 +++----- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/clients/android/native/src/wol.rs b/clients/android/native/src/wol.rs index 5e32d42..8b54299 100644 --- a/clients/android/native/src/wol.rs +++ b/clients/android/native/src/wol.rs @@ -23,7 +23,7 @@ pub extern "system" fn Java_io_unom_punktfunk_kit_NativeBridge_nativeWakeOnLan<' }; let last_ip: String = env .get_string(&last_ip) - .map(|s| Into::::into(s)) + .map(Into::::into) .unwrap_or_default(); let macs: Vec<[u8; 6]> = macs_csv .split(',') diff --git a/clients/windows/src/main.rs b/clients/windows/src/main.rs index a63d08f..958379e 100644 --- a/clients/windows/src/main.rs +++ b/clients/windows/src/main.rs @@ -43,6 +43,7 @@ mod trust; #[cfg(windows)] mod video; +#[cfg(windows)] mod wol; #[cfg(windows)] diff --git a/crates/punktfunk-core/src/wol.rs b/crates/punktfunk-core/src/wol.rs index b2d6a3d..e63642e 100644 --- a/crates/punktfunk-core/src/wol.rs +++ b/crates/punktfunk-core/src/wol.rs @@ -13,6 +13,7 @@ //! * the **limited broadcast** `255.255.255.255`, and //! * optionally a **unicast** to the host's last-known IP (covers the brief window where the //! host is reachable but hasn't re-advertised, and NICs that wake on a directed unicast), +//! //! on the two conventional WoL ports (9 and 7), repeated a few times to survive UDP loss. use std::io; @@ -36,7 +37,7 @@ const BURST: usize = 3; pub fn parse_mac(s: &str) -> Option { let mut m = [0u8; 6]; let mut n = 0; - for part in s.split(|c| c == ':' || c == '-') { + for part in s.split([':', '-']) { if n == 6 { return None; // too many octets } @@ -103,10 +104,7 @@ pub fn send_magic_packet(macs: &[Mac], last_known_ip: Option) -> io::R if sent_any { Ok(()) } else { - Err(io::Error::new( - io::ErrorKind::Other, - "no magic packet could be sent", - )) + Err(io::Error::other("no magic packet could be sent")) } }