fix(windows-installer): pf-vdisplay CI build - default target dir + non-fatal cat guard

The CI driver build panicked in wdk-sys's build script - "a Cargo.lock file should
exist in the same directory as the top-level Cargo.toml". wdk-build's
find_top_level_cargo_manifest() walks UP from OUT_DIR for the first ancestor holding a
Cargo.lock and explicitly does NOT support non-default target dirs - but
build-pf-vdisplay.ps1 pointed CARGO_TARGET_DIR at an out-of-tree dir (to isolate from
CI's shared C:\t), so no ancestor of OUT_DIR had a Cargo.lock. Build into the driver
workspace's DEFAULT target dir instead (its ancestors include the driver Cargo.lock);
the driver's own [workspace] already isolates it and it has no CMake deps needing C:\t.
Also make the Test-FileCatalog coverage guard non-fatal (it can't open a catalog
signed by a not-yet-trusted cert). Validated on the runner with CARGO_TARGET_DIR=C:\t.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

packaging/windows/build-pf-vdisplay.ps1

@@ -45,17 +45,22 @@ if (-not $env:Version_Number) { $env:Version_Number = '10.0.26100.0' }
 if (-not $env:LIBCLANG_PATH -and (Test-Path 'C:\Program Files\LLVM\bin\libclang.dll')) {
     $env:LIBCLANG_PATH = 'C:\Program Files\LLVM\bin'
 }
-# Isolate the driver's CARGO_TARGET_DIR from the host's (CI sets a shared C:\t): the driver is a
+# The driver MUST build into its DEFAULT target dir (under the driver workspace), NOT an external one:
-# SEPARATE workspace (own [workspace] + an explicit --target via .cargo/config), so give it its own
+# wdk-sys's build script calls wdk-build::find_top_level_cargo_manifest(), which walks UP from OUT_DIR
-# output tree both to avoid cross-workspace churn and to make the .dll path predictable here.
+# for the first ancestor holding a Cargo.lock (it explicitly "does not support non-default target
-$drvTarget = Join-Path (Split-Path -Parent $Out) 'pfvd-target'
+# directories"). CI sets a shared CARGO_TARGET_DIR=C:\t, whose ancestors have no Cargo.lock -> the build
+# script panics "a Cargo.lock file should exist in the same directory as the top-level Cargo.toml". So
+# clear CARGO_TARGET_DIR for this build and let cargo use <driver-workspace>\target (its ancestors
+# include the driver Cargo.lock). The driver has no CMake-from-source deps, so it doesn't need C:\t's
+# MAX_PATH dodge, and its own [workspace] keeps it isolated from the host's tree regardless.
+$drvTarget = Join-Path $DriversDir 'target'
 $dll = Join-Path $drvTarget 'x86_64-pc-windows-msvc\release\pf_vdisplay.dll'
 
 # --- 1. build (release) -----------------------------------------------------------------------
 if (-not $SkipBuild) {
-    Write-Host "==> cargo build --release (pf-vdisplay) in $DriversDir (target -> $drvTarget)"
+    Write-Host "==> cargo build --release (pf-vdisplay) in $DriversDir (default target -> $drvTarget)"
     $prevTarget = $env:CARGO_TARGET_DIR
-    $env:CARGO_TARGET_DIR = $drvTarget
+    Remove-Item Env:\CARGO_TARGET_DIR -ErrorAction SilentlyContinue
     Push-Location $DriversDir
     & cargo build --release
     $rc = $LASTEXITCODE
@@ -121,8 +126,12 @@ Export-Certificate -Cert $pubForCer -FilePath $sCer | Out-Null
 if ($cleanupCert) { Remove-Item "Cert:\CurrentUser\My\$($cleanupCert.Thumbprint)" -Force -ErrorAction SilentlyContinue }
 
 # --- 5. guard: assert the freshly-built catalog covers the inf + dll ---------------------------
-# (Built-from-source can't drift, but this catches a botched stampinf/Inf2Cat ordering before it ships.)
+# Built-from-source can't drift, but this catches a botched stampinf/Inf2Cat ordering. Test-FileCatalog
-$cat = Test-FileCatalog -CatalogFilePath $sCat -Path $Out -FilesToSkip 'pf_vdisplay.cat', 'punktfunk-driver.cer' -Detailed -ErrorAction SilentlyContinue
+# itself can't always OPEN a catalog signed by a not-yet-trusted cert (it throws UnableToOpenCatalogFile),
+# so treat ITS failure as inconclusive (warn) - but a real coverage miss still fails the build.
+$cat = $null
+try { $cat = Test-FileCatalog -CatalogFilePath $sCat -Path $Out -FilesToSkip 'pf_vdisplay.cat', 'punktfunk-driver.cer' -Detailed }
+catch { Write-Warning "catalog coverage guard inconclusive (Test-FileCatalog: $($_.Exception.Message))" }
 if ($cat) {
     $covered = @($cat.CatalogItems.Keys)
     foreach ($need in @('pf_vdisplay.inf', 'pf_vdisplay.dll')) {