fix(host): cover Codec::PyroWave in the Windows NVENC/AMF match arms
ci / web (push) Successful in 1m12s
ci / docs-site (push) Successful in 1m45s
decky / build-publish (push) Successful in 17s
docker / build-push (--build-arg FEDORA_VERSION=44, ci, ci/fedora-rpm.Dockerfile, punktfunk-fedora44-rpm) (push) Successful in 8s
docker / build-push (., web/Dockerfile, punktfunk-web) (push) Successful in 31s
arch / build-publish (push) Failing after 8m9s
docker / build-push (ci, ci/fedora-rpm.Dockerfile, punktfunk-fedora-rpm) (push) Successful in 7s
docker / build-push (ci, ci/rust-ci.Dockerfile, punktfunk-rust-ci) (push) Successful in 9s
docker / build-push (docs-site, docs-site/Dockerfile, punktfunk-docs) (push) Successful in 9s
ci / bench (push) Successful in 5m57s
android / android (push) Successful in 12m13s
ci / rust (push) Failing after 13m5s
deb / build-publish (push) Failing after 7m32s
rpm / build-publish (43, bazzite, punktfunk-fedora-rpm) (push) Failing after 7m30s
windows-host / package (push) Successful in 14m18s
rpm / build-publish (44, fedora-44, punktfunk-fedora44-rpm) (push) Failing after 9m37s
docker / deploy-docs (push) Successful in 25s
apple / swift (push) Successful in 4m51s
apple / screenshots (push) Successful in 20m29s

The nine non-exhaustive matches windows-host CI tripped on (run 9917) —
all inside encoder objects a PyroWave session can never open (the
open_video dispatch routes PyroWave to its own backend on Linux and
bails on Windows), so the arms are dispatch-guarded unreachable!().
Verified: cargo check -p punktfunk-host --features nvenc,amf-qsv
--release green on the windows-amd64 runner.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
2026-07-15 01:20:56 +02:00
parent e71cb9b7bd
commit 49ba1cd11b
2 changed files with 11 additions and 0 deletions
@@ -913,6 +913,7 @@ fn codec_props(codec: Codec) -> CodecProps {
intra_refresh: None, intra_refresh: None,
ltr: None, ltr: None,
}, },
Codec::PyroWave => unreachable!("PyroWave never opens the AMF backend"),
} }
} }
@@ -1525,6 +1526,7 @@ impl AmfEncoder {
)?; )?;
} }
} }
Codec::PyroWave => unreachable!("PyroWave never opens the AMF backend"),
} }
// Colour signalling, mirroring `open_win_encoder`: BT.709 limited (SDR) or BT.2020 PQ // Colour signalling, mirroring `open_win_encoder`: BT.709 limited (SDR) or BT.2020 PQ
// (HDR) — VUI on AVC/HEVC, sequence-header colour config on AV1. Required when HDR — a // (HDR) — VUI on AVC/HEVC, sequence-header colour config on AV1. Required when HDR — a
@@ -2171,6 +2173,7 @@ impl Encoder for AmfEncoder {
// The static KEY_FRAME_ALIGNED header-insertion mode already puts a sequence // The static KEY_FRAME_ALIGNED header-insertion mode already puts a sequence
// header OBU on every key frame; there is no per-surface twin. // header OBU on every key frame; there is no per-surface twin.
Codec::Av1 => {} Codec::Av1 => {}
Codec::PyroWave => unreachable!("PyroWave never opens the AMF backend"),
} }
} }
// LTR-RFI per-frame properties (design: the AMD twin of NVENC intra-refresh recovery). // LTR-RFI per-frame properties (design: the AMD twin of NVENC intra-refresh recovery).
@@ -244,6 +244,7 @@ fn codec_guid(codec: Codec) -> nv::GUID {
Codec::H264 => nv::NV_ENC_CODEC_H264_GUID, Codec::H264 => nv::NV_ENC_CODEC_H264_GUID,
Codec::H265 => nv::NV_ENC_CODEC_HEVC_GUID, Codec::H265 => nv::NV_ENC_CODEC_HEVC_GUID,
Codec::Av1 => nv::NV_ENC_CODEC_AV1_GUID, Codec::Av1 => nv::NV_ENC_CODEC_AV1_GUID,
Codec::PyroWave => unreachable!("PyroWave never opens the direct-NVENC backend"),
} }
} }
@@ -757,6 +758,7 @@ impl NvencD3d11Encoder {
} }
// H.264 has no tier; the preset default level is already autoselect. // H.264 has no tier; the preset default level is already autoselect.
Codec::H264 => {} Codec::H264 => {}
Codec::PyroWave => unreachable!("PyroWave never opens the direct-NVENC backend"),
} }
// Chroma + bit depth. Full-chroma 4:4:4 (HEVC Range Extensions) takes precedence and composes // Chroma + bit depth. Full-chroma 4:4:4 (HEVC Range Extensions) takes precedence and composes
@@ -795,6 +797,7 @@ impl NvencD3d11Encoder {
cfg.encodeCodecConfig.hevcConfig.set_pixelBitDepthMinus8(2); cfg.encodeCodecConfig.hevcConfig.set_pixelBitDepthMinus8(2);
// 10 - 8 // 10 - 8
} }
Codec::PyroWave => unreachable!("PyroWave never opens the direct-NVENC backend"),
Codec::Av1 => { Codec::Av1 => {
cfg.encodeCodecConfig.av1Config.set_pixelBitDepthMinus8(2); cfg.encodeCodecConfig.av1Config.set_pixelBitDepthMinus8(2);
// The input rides at its real depth; NVENC upconverts (mirrors the HEVC path). // The input rides at its real depth; NVENC upconverts (mirrors the HEVC path).
@@ -864,6 +867,7 @@ impl NvencD3d11Encoder {
av1.matrixCoefficients = mat; av1.matrixCoefficients = mat;
av1.colorRange = 0; // studio/limited swing av1.colorRange = 0; // studio/limited swing
} }
Codec::PyroWave => unreachable!("PyroWave never opens the direct-NVENC backend"),
} }
} }
@@ -885,6 +889,7 @@ impl NvencD3d11Encoder {
Codec::Av1 => { Codec::Av1 => {
cfg.encodeCodecConfig.av1Config.maxNumRefFramesInDPB = RFI_DPB; cfg.encodeCodecConfig.av1Config.maxNumRefFramesInDPB = RFI_DPB;
} }
Codec::PyroWave => unreachable!("PyroWave never opens the direct-NVENC backend"),
} }
} }
Ok(cfg) Ok(cfg)
@@ -1456,6 +1461,9 @@ impl Encoder for NvencD3d11Encoder {
} }
// AV1 mastering/CLL ride METADATA OBUs, not SEI — separate follow-up. // AV1 mastering/CLL ride METADATA OBUs, not SEI — separate follow-up.
Codec::Av1 => {} Codec::Av1 => {}
Codec::PyroWave => {
unreachable!("PyroWave never opens the direct-NVENC backend")
}
} }
} }
(api().encode_picture)(self.encoder, &mut pic) (api().encode_picture)(self.encoder, &mut pic)