unom/punktfunk
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 21 Wiki Activity

fix(apple/test): unwrap optional leaseSeconds in RumbleTuningTests
ci / web (pull_request) Successful in 51s
Details
windows / build (aarch64-pc-windows-msvc) (pull_request) Successful in 59s
Details
ci / docs-site (pull_request) Successful in 1m1s
Details
windows / build (x86_64-pc-windows-msvc) (pull_request) Successful in 1m17s
Details
apple / swift (pull_request) Successful in 4m50s
Details
apple / screenshots (pull_request) Has been skipped
Details
ci / bench (pull_request) Successful in 6m18s
Details
android / android (pull_request) Successful in 9m4s
Details
ci / rust (pull_request) Successful in 18m21s
Details

Browse Source 
RumbleTuning.leaseSeconds returns TimeInterval? (nil for the no-lease sentinel);
XCTAssertEqual(_, _, accuracy:) needs a non-optional Double. Coalesce with .nan
so a nil (which must not happen for a real ttl) still fails the assertion.
Test-only — the production Swift built clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Enrico Bühler
2026-07-11 03:16:56 +02:00
parent 01d10f46ea
commit 4873e8925d
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clients/apple/Tests/PunktfunkKitTests/RumbleTuningTests.swift
+4 -4
View File
@@ -79,10 +79,10 @@ final class RumbleTuningTests: XCTestCase {
// The legacy no-lease sentinel → nil (fall back to the staleness watchdog). // The legacy no-lease sentinel → nil (fall back to the staleness watchdog).
XCTAssertNil(RumbleTuning.leaseSeconds(ttlMs: RumbleTuning.noTTL)) XCTAssertNil(RumbleTuning.leaseSeconds(ttlMs: RumbleTuning.noTTL))
XCTAssertEqual(RumbleTuning.noTTL, UInt32.max) XCTAssertEqual(RumbleTuning.noTTL, UInt32.max)
// A real lease → its duration in seconds. // A real lease → its duration in seconds (non-nil for any ttl != noTTL).
XCTAssertEqual(RumbleTuning.leaseSeconds(ttlMs: 400), 0.4, accuracy: 1e-9) XCTAssertEqual(RumbleTuning.leaseSeconds(ttlMs: 400) ?? .nan, 0.4, accuracy: 1e-9)
XCTAssertEqual(RumbleTuning.leaseSeconds(ttlMs: 0), 0, accuracy: 1e-9) XCTAssertEqual(RumbleTuning.leaseSeconds(ttlMs: 0) ?? .nan, 0, accuracy: 1e-9)
XCTAssertEqual(RumbleTuning.leaseSeconds(ttlMs: 150), 0.15, accuracy: 1e-9) XCTAssertEqual(RumbleTuning.leaseSeconds(ttlMs: 150) ?? .nan, 0.15, accuracy: 1e-9)
} }
func testEnvelopeLeaseBoundsMotorLifeTighterThanTheLegacyWatchdog() { func testEnvelopeLeaseBoundsMotorLifeTighterThanTheLegacyWatchdog() {