unom/punktfunk
5
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 39 Wiki Activity

fix(winget): the Log switch used |LOGPATH|, which winget never substitutes

Browse Source 
Second field report on 0.20.0's winget path, and independent of the conflict
abort in 37781a61: an INTERACTIVE install through UniGetUI dies before the
wizard with Inno's "Error creating log file: The filename, directory name, or
volume label syntax is incorrect."

`<LOGPATH>` is winget's own token and the only spelling it replaces — the
schema this manifest declares says so verbatim ("<LOGPATH> token can be included
in the switch value so that winget will replace the token with user provided
path"). We shipped `|LOGPATH|`, which is not a token, so winget passed the
literal string to Inno; `|` is not legal in a Windows filename, and Inno refuses
before doing anything else.

Worse than the conflict abort in two ways: it is not confined to silent installs
— it fires in EVERY mode for any caller that requests a log — and UniGetUI
requests one by default, so a GUI user cannot install at all. Confirmed against
the live source, which is serving the broken switch to everyone right now:
  curl -s https://winget.punktfunk.unom.io/packageManifests/unom.PunktfunkHost
  → "Log": "/LOG=\"|LOGPATH|\""

Guarded by the suite that exists for exactly this class of defect (a wrong
response shape does not fail loudly — winget just says "no package found"). The
new check accepts an absent Log switch, requires <LOGPATH> when present, and
rejects any |TOKEN| spelling. Mutation-verified: restoring |LOGPATH| fails the
check naming the offending value, and the corrected manifest passes 29/29.

⚠ Fixing the template does NOT fix the live catalogue: it is derived from the
manifest trio attached to each release, so the corrected switch only reaches
users when a release carries it.
This commit is contained in:
enricobuehler
2026-07-27 10:28:59 +02:00
parent 37781a610f
commit 4114dfeff7
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packaging/winget/unom.PunktfunkHost.installer.yaml
+8 -1
View File
@@ -35,7 +35,14 @@ InstallerSwitches:
# gamestream, allowpublicfw, startservice, trayicon
Silent: /VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP-
SilentWithProgress: /SILENT /SUPPRESSMSGBOXES /NORESTART /SP-
Log: /LOG="|LOGPATH|"
# <LOGPATH> is winget's OWN token and the only spelling it substitutes (see the schema this file
# declares: "…<LOGPATH> token can be included in the switch value so that winget will replace the
# token with user provided path"). It was written |LOGPATH| — not a token, so winget passed the
# literal string through and Inno rejected it: `|` is not legal in a Windows filename, giving
# "Error creating log file: The filename, directory name, or volume label syntax is incorrect."
# That aborted the install in EVERY mode, interactive included, for any caller that asks for a
# log — UniGetUI does so by default, which is how it was reported.
Log: /LOG="<LOGPATH>"
# Inno writes its ARP entry under <AppId>_is1; this is what correlates an installed host with the
# package for `winget list` / `winget upgrade`. Must track AppId in the .iss.