unom/punktfunk
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 18 Wiki Activity

fix(apple): disarm CHHapticEngine handlers with no-ops, not nil

Browse Source 
stoppedHandler/resetHandler are non-optional closures on the CI SDK
((StoppedReason)->() and ()->()), so assigning nil fails to compile
(apple.yml). Assign no-op closures to disarm them before engine.stop()
-- same re-entrancy guard intent, type-correct.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Enrico Bühler
2026-06-18 21:20:37 +00:00
parent c358b510e5
commit 26084969a9
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clients/apple/Sources/PunktfunkKit/GamepadFeedback.swift
+4 -3
View File
@@ -186,9 +186,10 @@ private final class RumbleRenderer: @unchecked Sendable {
private func teardown() { private func teardown() {
for m in [low, high].compactMap({ $0 }) { for m in [low, high].compactMap({ $0 }) {
// Drop the handlers before stopping so stop() can't re-enter teardown via stoppedHandler. // Disarm the handlers before stopping so stop() can't re-enter teardown via them.
m.engine.stoppedHandler = nil // (Both properties are non-optional closures on this SDK, so assign no-ops, not nil.)
m.engine.resetHandler = nil m.engine.stoppedHandler = { _ in }
m.engine.resetHandler = {}
try? m.player.stop(atTime: CHHapticTimeImmediate) try? m.player.stop(atTime: CHHapticTimeImmediate)
m.engine.stop() m.engine.stop()
} }