unom/punktfunk
1
0
Fork 0
Code Issues Pull Requests Actions 15 Packages Projects Releases 18 Wiki Activity

fix(android): DataSpace impls Display not Debug — use {ds} in HDR logs

Browse Source 
ndk's DataSpace derives Copy/PartialEq/Eq and impls Display (no Debug), so the
{ds:?} in the HDR dataspace log statements wouldn't compile under cargo-ndk.
Host clippy can't catch it — decode.rs is android-gated. Switch to {ds}.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Enrico Bühler
2026-06-18 22:13:20 +00:00
parent f4c0e7e805
commit 1d78c29129
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clients/android/native/src/decode.rs
+2 -2
View File
@@ -218,10 +218,10 @@ fn drain(codec: &MediaCodec, window: &NativeWindow, applied_ds: &mut Option<Data
match window.set_buffers_data_space(ds) { match window.set_buffers_data_space(ds) {
Ok(()) => { Ok(()) => {
*applied_ds = Some(ds); *applied_ds = Some(ds);
log::info!("decode: HDR stream → Surface dataspace {ds:?}"); log::info!("decode: HDR stream → Surface dataspace {ds}");
} }
Err(e) => log::warn!( Err(e) => log::warn!(
"decode: set_buffers_data_space({ds:?}) failed (non-fatal): {e}" "decode: set_buffers_data_space({ds}) failed (non-fatal): {e}"
), ),
} }
} }