Files
punktfunk/web/src/sections/Store/Sources.tsx
T
enricobuehlerandClaude Opus 5 4575134c21 fix(web): one bad password from anywhere stops locking out the whole console
The console's login throttle was documented as per-IP and was not. Nitro's
`localFetch` hands the app a synthetic request whose socket has no
`remoteAddress`, so `getRequestIP()` returned undefined for every request and
every attempt was charged to one shared "unknown" bucket. Five wrong guesses
from any LAN peer locked out everyone — including the operator, and including
the update-apply route, which shares that budget. The Bun entry is the only
place the real peer is knowable, so it now stamps it into a header (deleting
any client-supplied copy first) and `peerAddress()` reads it back.

Verified on a real build bound to 0.0.0.0: seven wrong logins from 127.0.0.1
lock 127.0.0.1 out, a different peer still logs in on the first try, and a
request forging the header is charged to its real address.

Also on the way through:

- Installing an unreviewed package and adding a catalog source now re-ask for
  the console password, like applying an update already did. A 7-day session
  cookie should not be able to run new code on the host, and `store/install`
  with `accept_unverified` did exactly that through the generic passthrough.
  The gate sits at the trust boundary — adding a source, or a raw spec — not
  on every install from a source the operator already chose to trust.
- The ui-credential denylist is matched against the normalised path too, so
  `/api//v1/...` and friends can no longer walk around it.
- The console serves nosniff, a no-referrer policy, and a CSP that pins
  frame-ancestors, object-src and base-uri.
- A plugin UI's response no longer re-emits the content-encoding that `fetch`
  already decoded (which made compressed plugin pages fail to load), no longer
  sets cookies on the console's origin, and OPTIONS reaches the plugin instead
  of being refused 405 by us.
- An unreachable host reads as 502 on these routes, matching the passthrough,
  instead of a bare 500.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-01 00:20:10 +02:00

394 lines
12 KiB
TypeScript

import { toast } from "@unom/ui/toast";
import {
AlertTriangle,
Lock,
RefreshCw,
ShieldCheck,
ShieldOff,
Trash2,
} from "lucide-react";
import { type FC, type FormEvent, useEffect, useState } from "react";
import { ApiError } from "@/api/fetcher";
import {
type SourceBody,
type StoreSource,
useDeleteSource,
useRefreshCatalog,
useSetSource,
useStoreSources,
} from "@/api/store";
import { QueryState } from "@/components/query-state";
import { Badge } from "@/components/ui/badge";
import { Button } from "@/components/ui/button";
import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "@/components/ui/dialog";
import { Input } from "@/components/ui/input";
import { Label } from "@/components/ui/label";
import { m } from "@/paraglide/messages";
/** A source the operator has filled in but not yet agreed to trust. The console password is NOT
* part of the draft — it is collected by the trust dialog, at the moment the decision is made. */
type SourceDraft = Omit<SourceBody, "password"> & { name: string };
/** Unix seconds → a locale date-time, or "never" for a source that has never fetched. */
const fmtFetched = (secs: number): string =>
secs > 0 ? new Date(secs * 1000).toLocaleString() : m.store_source_never();
/**
* Container: the catalog sources. Owns the source listing, the refresh-all action, and add/remove.
* Adding is a two-step: the form collects the source, and a one-time trust dialog states plainly
* what trusting a third-party catalog means before anything is written to the host.
*/
export const SourcesTab: FC = () => {
const sources = useStoreSources();
const refresh = useRefreshCatalog();
const save = useSetSource();
const remove = useDeleteSource();
// The draft waiting on the trust dialog, and a key that re-mounts (and so clears) the form.
const [draft, setDraft] = useState<SourceDraft | null>(null);
const [formKey, setFormKey] = useState(0);
const [wrongPassword, setWrongPassword] = useState(false);
const onRefresh = () =>
refresh.mutate(undefined, {
onError: () => toast.error(m.store_refresh_failed()),
});
const onConfirmAdd = async (password: string) => {
if (!draft) return;
setWrongPassword(false);
try {
await save.mutateAsync({ ...draft, password });
setDraft(null);
setFormKey((k) => k + 1);
} catch (e) {
// A rejected password keeps the dialog open so the operator can retry without refilling
// the form; anything else is a genuine failure to write the source.
if (e instanceof ApiError && e.status === 401) {
setWrongPassword(true);
return;
}
toast.error(m.store_add_source_failed());
}
};
const onRemove = async (source: StoreSource) => {
if (!confirm(m.store_source_remove_confirm({ name: source.name }))) return;
try {
await remove.mutateAsync(source.name);
} catch (e) {
// 403 is the host refusing to drop its built-in catalog — say exactly that.
toast.error(
e instanceof ApiError && e.status === 403
? m.store_source_builtin_locked()
: m.store_source_remove_failed(),
);
}
};
return (
<div className="flex flex-col gap-card">
<SourceList
sources={sources}
busyName={remove.isPending ? (remove.variables ?? null) : null}
isRefreshing={refresh.isPending}
onRefresh={onRefresh}
onRemove={onRemove}
/>
<AddSourceForm
key={formKey}
onSubmit={setDraft}
isSaving={save.isPending}
/>
<TrustSourceDialog
draft={draft}
isSaving={save.isPending}
wrongPassword={wrongPassword}
onCancel={() => {
setDraft(null);
setWrongPassword(false);
}}
onConfirm={onConfirmAdd}
/>
</div>
);
};
/** The source table: health per source, with the built-in one locked. */
export const SourceList: FC<{
sources: {
data?: StoreSource[];
isLoading: boolean;
error: unknown;
refetch?: () => void;
};
/** Name of the source whose delete is in flight, or null. */
busyName: string | null;
isRefreshing: boolean;
onRefresh: () => void;
onRemove: (source: StoreSource) => void;
}> = ({ sources, busyName, isRefreshing, onRefresh, onRemove }) => {
const rows = sources.data ?? [];
return (
<Card>
<CardHeader className="flex-row items-center justify-between space-y-0">
<CardTitle>{m.store_sources_title()}</CardTitle>
<Button
variant="outline"
size="sm"
disabled={isRefreshing}
onClick={onRefresh}
>
<RefreshCw
className={isRefreshing ? "size-4 animate-spin" : "size-4"}
/>
{m.store_refresh_all()}
</Button>
</CardHeader>
<CardContent className="space-y-4">
<p className="max-w-prose text-sm text-muted-foreground">
{m.store_sources_help()}
</p>
<QueryState
isLoading={sources.isLoading}
error={sources.error}
refetch={sources.refetch}
>
<div className="flex flex-col gap-3">
{rows.map((s) => (
<div
key={s.name}
className="flex flex-col gap-2 rounded-lg border p-3 sm:flex-row sm:items-start"
>
<div className="min-w-0 flex-1 space-y-1">
<div className="flex flex-wrap items-center gap-2">
<span className="font-medium">{s.name}</span>
{s.builtin && (
<Badge variant="secondary" className="gap-1">
<Lock className="size-3" />
{m.store_source_builtin()}
</Badge>
)}
{s.signed ? (
<Badge variant="outline" className="gap-1">
<ShieldCheck className="size-3" />
{m.store_source_signed()}
</Badge>
) : (
<Badge
variant="outline"
className="gap-1 border-amber-600/40 text-amber-600 dark:border-amber-500/40 dark:text-amber-500"
>
<ShieldOff className="size-3" />
{m.store_source_unsigned()}
</Badge>
)}
{s.stale && (
<Badge
variant="outline"
className="gap-1 border-amber-600/40 text-amber-600 dark:border-amber-500/40 dark:text-amber-500"
>
<AlertTriangle className="size-3" />
{m.store_source_stale()}
</Badge>
)}
</div>
<p className="truncate font-mono text-xs text-muted-foreground">
{s.url}
</p>
<p className="text-xs text-muted-foreground">
{m.store_source_entries({ count: s.entry_count })} ·{" "}
{m.store_source_fetched({ when: fmtFetched(s.fetched_at) })}
</p>
{s.error && (
<p className="text-xs text-destructive">{s.error}</p>
)}
</div>
{/* The built-in catalog gets no delete button at all — not a disabled one. */}
{!s.builtin && (
<Button
variant="ghost"
size="icon"
aria-label={m.store_source_remove()}
disabled={busyName === s.name}
onClick={() => onRemove(s)}
>
<Trash2 className="size-4 text-destructive" />
</Button>
)}
</div>
))}
</div>
</QueryState>
</CardContent>
</Card>
);
};
/** The add-source form. Reports a draft; the parent takes it through the trust dialog. */
export const AddSourceForm: FC<{
onSubmit: (draft: SourceDraft) => void;
isSaving: boolean;
}> = ({ onSubmit, isSaving }) => {
const [name, setName] = useState("");
const [url, setUrl] = useState("");
const [publicKey, setPublicKey] = useState("");
const handleSubmit = (e: FormEvent) => {
e.preventDefault();
const key = publicKey.trim();
if (!name.trim() || !url.trim()) return;
onSubmit({
name: name.trim(),
url: url.trim(),
public_key: key ? key : undefined,
});
};
return (
<Card className="max-w-xl">
<CardHeader>
<CardTitle>{m.store_add_source_title()}</CardTitle>
</CardHeader>
<CardContent>
<form onSubmit={handleSubmit} className="space-y-4">
<div className="space-y-2">
<Label htmlFor="store-source-name">
{m.store_field_source_name()}
</Label>
<Input
id="store-source-name"
required
autoComplete="off"
spellCheck={false}
value={name}
onChange={(e) => setName(e.target.value)}
/>
</div>
<div className="space-y-2">
<Label htmlFor="store-source-url">
{m.store_field_source_url()}
</Label>
<Input
id="store-source-url"
required
type="url"
inputMode="url"
value={url}
onChange={(e) => setUrl(e.target.value)}
/>
</div>
<div className="space-y-2">
<Label htmlFor="store-source-key">
{m.store_field_source_key()}
</Label>
<Input
id="store-source-key"
autoComplete="off"
spellCheck={false}
placeholder="ed25519:…"
value={publicKey}
onChange={(e) => setPublicKey(e.target.value)}
/>
<p className="text-xs text-muted-foreground">
{m.store_field_source_key_help()}
</p>
</div>
<Button
type="submit"
disabled={isSaving || !name.trim() || !url.trim()}
>
{m.store_add_source()}
</Button>
</form>
</CardContent>
</Card>
);
};
/** The one-time trust warning shown before a third-party catalog is written to the host. */
export const TrustSourceDialog: FC<{
draft: SourceDraft | null;
isSaving: boolean;
onCancel: () => void;
onConfirm: (password: string) => void;
/** Set when the BFF rejected the password (401) — say so and keep the dialog open. */
wrongPassword?: boolean;
}> = ({ draft, isSaving, onCancel, onConfirm, wrongPassword }) => {
const [password, setPassword] = useState("");
// The dialog stays mounted between drafts; clear the password whenever it closes.
useEffect(() => {
if (!draft) setPassword("");
}, [draft]);
return (
<Dialog open={draft !== null} onOpenChange={(open) => !open && onCancel()}>
{draft && (
<DialogContent>
<DialogHeader>
<DialogTitle className="flex items-center gap-2">
<AlertTriangle className="size-5 shrink-0 text-amber-600 dark:text-amber-500" />
{m.store_source_trust_title()}
</DialogTitle>
<DialogDescription>
{m.store_source_trust_body({ name: draft.name })}
</DialogDescription>
</DialogHeader>
<p className="rounded-md bg-muted px-3 py-2 font-mono text-xs break-all text-muted-foreground">
{draft.url}
</p>
{!draft.public_key && (
<p className="rounded-md border border-amber-600/40 bg-amber-500/10 px-3 py-2 text-sm text-amber-600 dark:border-amber-500/40 dark:text-amber-500">
{m.store_source_trust_unsigned()}
</p>
)}
{/* Adding a source is a trust-root change: every future install rides on it, so the
console password is re-entered here and verified at the BFF, exactly as for a
host update. */}
<div className="space-y-2">
<Label htmlFor="store-source-password">
{m.store_source_password()}
</Label>
<Input
id="store-source-password"
type="password"
autoComplete="current-password"
value={password}
onChange={(e) => setPassword(e.target.value)}
/>
{wrongPassword && (
<p role="alert" className="text-xs text-destructive">
{m.update_apply_wrong_password()}
</p>
)}
</div>
<DialogFooter>
<Button variant="outline" onClick={onCancel} disabled={isSaving}>
{m.common_cancel()}
</Button>
<Button
disabled={isSaving || password.length === 0}
onClick={() => onConfirm(password)}
>
{m.store_source_trust_confirm()}
</Button>
</DialogFooter>
</DialogContent>
)}
</Dialog>
);
};