2 Commits

Include renames

Author	SHA1	Message	Date
enricobuehler	3be7d1d4f8	feat(web): the console asks its own questions ... Follow-up to a85e8452, closing the three items that sweep flagged and left. SIXTEEN BROWSER DIALOGS, GONE. Every destructive action in an otherwise fully branded console handed off to `window.confirm` — a grey OS box with the page's URL in it, no brand, no red on a delete, and untouchable by any story or screenshot, which is part of why it survived this long. They are replaced by one promise-based surface (components/dialogs.tsx) rather than a dialog per call site. The native calls were EXPRESSIONS — `if (!confirm(…)) return;` — threaded through mutation handlers; rewriting each into "hold the pending action in state, render a dialog, run it from onConfirm" would have put dialog machinery in every section file and turned each linear handler inside out. Returning a promise keeps them the shape they already were, and it is what let the navigation guard come along too: TanStack's `shouldBlockFn` accepts `Promise<boolean>`. `beforeunload` necessarily stays native — a reload is the browser's dialog to draw, and it will not wait on ours. No warning copy was rewritten. Each message was SPLIT at its existing sentence boundary: the question becomes the dialog's title, the consequence its body, and "Continue?" is dropped where the affirmative button now carries the verb ("Delete", "Uninstall", "Unpair", "Stop every session"). 16 new keys, en and de in parity at 629. Verified by driving the real dialogs in a headless browser — all seven contract checks pass, including the two that would be invisible until they bit: Escape SETTLES the promise (an unsettled one would hang a mutation handler forever with no error), and a cancelled prompt resolves null rather than "", so a caller can still tell "backed out" from "cleared the field". FOUR OF THE SEVEN NUMERIC FIELDS became InputNumber; three deliberately did not, and now say why in place. The layout X/Y pair had a real defect: a screen left of the origin has a negative coordinate, and `Number("-") || 0` rewrote the lone minus sign to "0" before the digits could be typed. Measured on the built page: the field can now be emptied to retype instead of snapping to its floor, and 900 in a 1..=16 field clamps to 16. The three left alone cannot take it — the grace seconds field writes to the HOST on blur (InputNumber commits while typing, so its clamp would race the apply), and the library's year/players are OPTIONAL, where `value: number` has no way to say "unset" and would invent a year for every entry without one. The select's highlighted row moves off @unom/ui's neutral grey onto the brand wash the nav and the preset cards already use. The Displays story earned its keep immediately: adding `useDialogs` to that page broke it in Storybook, because the provider was mounted in __root and nowhere else. It belongs beside the other app-level providers in .storybook/preview.	2026-08-07 22:56:46 +02:00
enricobuehler	bd383f1820	feat(web): one Game sources surface, launcher rail, and the migration nudge ... M4 of design/library-scanner-plugins-implementation-plan.md, plus WP6.2. WP4.1 — SourceToggles and ProvidersCard merge into Library/Sources.tsx. They were two cards because they were two different things: scanners were compiled into the host, plugins were an afterthought. After the extraction they are the same thing — the host reports ONE list of sources whose ids match whether they came from a built-in scanner or the plugin replacing it — so one surface is both simpler and the only honest presentation. Each row carries its toggle, a running/stopped badge for plugin sources, an entry count, filter, settings and an uninstall that offers to remove the games too. An "Add a source" rail lists uncatalogued library plugins with a "Detected" badge; `detected` is deliberately tri-state, so only a POSITIVE probe badges — an entry with no probes for this platform is unknown, and calling that "not installed" would be a lie. The settings drawer (SourceSettings.tsx) renders a generic form from the plugin's own JSON Schema over GET/PUT /__config, through the existing session-gated /plugin-ui/<id>/ proxy — zero new host surface, and the browser never learns the plugin's port or secret. It flattens allOf branches (effect nests a checked schema's annotations there, so a form reading only the top level silently loses every title and default) and falls back to a JSON editor when any field is a shape it cannot express — partial rendering would be worse than none, because a field missing from the form is a setting the operator cannot change. WP4.2 — uiPlugins() now excludes category "library", which covers both the sidebar and the mobile overflow since they share the selector. The /plugins/$pluginId/$ route still resolves, so existing deep links keep working; library plugins are just not advertised. WP4.3 — LibraryGrid groups role:"launcher" entries into a rail above the grid, and the empty state points at the sources surface rather than leaving a bare grid (after extraction, "no games" is the expected first-run state). WP6.2 — a migration banner offering one install per still-built-in scanner whose plugin is catalogued. One button per scanner, never a single "migrate everything" and never a silent auto-install: installing code stays an explicit operator act, and per-scanner is what makes it safe to repeat (the claim suppresses the built-in idempotently, so a half-finished migration is a valid state). WP4.4 — i18n en+de (kept under the existing "Game sources" label rather than minting a third "Plugins"), Storybook stories for the sources card in three states, the launcher rail and the banner. Gates: orval regen, tsc clean, vite build clean, check-i18n green at 595 messages for both locales. Still owed: the browser click-through (the store's Tabs-theme bug shipped through green types and lint), and an AppShell nav story — that one needs the plugins query mocked, which does not exist in this Storybook setup yet.	2026-08-05 10:03:24 +02:00